Review 10.4 Merged

75330[BUGFIX] Raise minimum version of symfony/mime to 4.4.16 / 5.1.8

Oliver Hader CR +2 V +2 Easy +3 −3 updated 07/29/22, 11:04

Commit message

A serialization issue has been fixed in symfony/mime 4.4.16 / 5.1.8
which has to be used as minimum version.

https://github.com/symfony/symfony/commit/fd99eb26d893390b45c214f4884fea090f1c1178

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 1622

  1. Oliver Hader uploaded patch set 1 07/29/22, 09:52

  2. core-ci voted on patch set 1 V -1 07/29/22, 09:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29685

  3. Oliver Hader uploaded patch set 2 07/29/22, 09:57

  4. core-ci voted on patch set 2 V +1 07/29/22, 10:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29686

  5. Oliver Klee commented on patch set 2 07/29/22, 10:06

    composer.json:74

    We'll also need to update the minimum 5.x version to always have the fix as 5.0.0 does not have it yet: https://github.com/symfony/symfony/blob/v5.0.0/src/Symfony/Component/Mime/RawMessage.php (I have not researched yet which 5.x is needed. As 5.4.x is the only supported 5.x branch according to https://symfony.com/releases, I propose we use the latest 5.4 version 5.4.10.)
  6. core-ci commented on patch set 2 07/29/22, 10:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29687

  7. Andreas Kienast commented on patch set 2 07/29/22, 10:25

    composer.json:74 Reply

  8. Stefan Bürk uploaded patch set 3 07/29/22, 10:31

  9. Stefan Bürk commented on patch set 3 07/29/22, 10:32

    composer.json:74 Reply

    Hope that's okay for Oliver. Done.
  10. Oliver Hader voted on patch set 3 CR -1 07/29/22, 10:33

  11. Oliver Hader uploaded patch set 4 07/29/22, 10:34

  12. Stefan Bürk updated the commit message in patch set 5 07/29/22, 10:36

  13. Simon Schaufelberger commented on patch set 5 07/29/22, 10:38

    now the commands are gone
  14. core-ci voted on patch set 3 V +1 07/29/22, 10:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29690

  15. Oliver Klee voted on patch set 5 CR +1 07/29/22, 10:40

  16. core-ci voted on patch set 4 V +1 07/29/22, 10:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29691

  17. Stefan Bürk voted on patch set 5 V +1 CR +1 07/29/22, 10:42

  18. core-ci voted on patch set 5 V +1 07/29/22, 10:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29692

  19. Oliver Klee voted on patch set 5 V +1 07/29/22, 11:02

  20. Stefan Bürk voted on patch set 5 V +2 CR +2 07/29/22, 11:03

  21. Stefan Bürk commented on patch set 5 07/29/22, 11:04

    Reply

    We ommit this now, not sure which commands oliver executed here exactly.
  22. Stefan Bürk merged patch set 6 07/29/22, 11:04