Review 11.5 Merged

75335[BUGFIX] Ensure deterministic sorting in `PageTreeRepository`

Stefan Bürk CR +2 V +2 Easy +7 −1 updated 07/30/22, 21:47

Commit message

Using database queries without deterministic sorting
definition may lead to unreliabe resultsets in some
dbms type and version, which also may change over time.
Thus it's good practice to have proper defined sorting
for queries, at least if result relies on a constant
and reliable result sorting.

With #96512 and #97774 additional tests has been added,
which showed the unreliable of these database queries,
blocking the bugfix backport to TYPO3 v10.4.

This patch adds sorting definition to two db queries in
`\TYPO3\CMS\Backend\Tree\Repository\PageTreeRepository`
to ensure consistent results in a deterministic manner
and make it possible to provide the related bugfix for
TYPO3 v10.4.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 3

Files 1