Review 11.5 Merged

75361[BUGFIX] Use nullabe return type for method returning null

Stefan Bürk CR +2 V +2 Easy +1 −1 updated 08/07/22, 17:30

Commit message

To avoid a type error the method
`EditDocumentController::generatePreviewCode`
must also allow null as return value because the called
method `PreviewUriBuilder::buildImmediateActionElement`
can return null as well.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
  • Verified V +2 Done
    • Stefan Bürk +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 34

  1. Stefan Bürk commented on patch set 1 08/07/22, 17:16

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 08/07/22, 17:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29928

  3. Stefan Bürk voted on patch set 1 V +2 CR +2 08/07/22, 17:30

  4. Stefan Bürk merged patch set 2 08/07/22, 17:30