Review main Merged

75376[BUGFIX] Use correct fluid variable name in AnalyzerTreePanel.html

Christian Keuerleber CR +2 V +2 Easy +1 −1 updated 08/09/22, 14:15

Commit message

With introducing the overhaul of the TypoScript parser and the
related parts like the ObjectBrowser and Template Analyzer, it
has been overseen that a invalid variable has been used in a
fluid partial.

This patch changes the partial to use the correct variable.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1012

  1. Christian Keuerleber uploaded patch set 1 08/05/22, 20:17

  2. core-ci voted on patch set 1 V +1 08/05/22, 20:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29850

  3. Simon Schaufelberger commented on patch set 1 08/05/22, 20:32

    If possible avoid using the word "fix" and write instead what you actually fix.
    Start the sentence with an uppercase letter. Have a look at https://docs.typo3.org/m/typo3/guide-contributionworkflow/main/en-us/Appendix/CommitMessage.html for great commit messages.
  4. Stefan Bürk uploaded patch set 2 08/09/22, 13:31

  5. Stefan Bürk commented on patch set 2 08/09/22, 13:31

    How can this be reprodi

    Reply

    Done

    Reply

    Done
  6. Stefan Bürk commented on patch set 2 08/09/22, 13:31

    Reply

    Ignore that ;) Slipped in ...
  7. Stefan Bürk voted on patch set 2 V +1 CR +1 08/09/22, 13:33

  8. Stefan Bürk commented on patch set 2 08/09/22, 13:36

    Thanks for the patch Christian, nice catch !
  9. core-ci voted on patch set 2 V +1 08/09/22, 13:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29975

  10. Simon Schaufelberger voted on patch set 2 V +1 CR +1 08/09/22, 14:01

  11. Christian Kuhn commented on patch set 2 V +2 CR +2 08/09/22, 14:15

    Thanks for the patch Christian! This one slipped through when I polished the analyzer code to make it merge-ready. Good catch.
  12. Christian Kuhn merged patch set 3 08/09/22, 14:15