Review main Abandoned

75384[TASK] Make public resource URLs better readable by default

André Buchmann CR 0 V 0 Easy +37 −6 updated 05/15/24, 15:07

Commit message

Use vendor/package name instead of hash for public resource urls

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 2

Review log 1421

  1. André Buchmann uploaded patch set 1 08/05/22, 23:05

  2. core-ci voted on patch set 1 V -1 08/05/22, 23:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29877

  3. Simon Schaufelberger commented on patch set 1 CR -1 08/05/22, 23:17

    PathUtility.php:102

    looks like WIP

    PathUtility.php:132

    please don't touch lines which are not part of the actual patch!

    PathUtility.php:145

    please don't touch lines which are not part of the actual patch!

    PathUtility.php:349

    please don't touch lines which are not part of the actual patch!
  4. André Buchmann uploaded patch set 2 08/06/22, 00:33

  5. core-ci voted on patch set 2 V +1 08/06/22, 00:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29882

  6. André Buchmann commented on patch set 2 08/06/22, 00:42

    PathUtility.php:102 Reply

    Thx for review. Accidentally left over :-(

    PathUtility.php:132 Reply

    Done

    PathUtility.php:145 Reply

    Done

    PathUtility.php:349 Reply

    Done
  7. Simon Schaufelberger wrote 08/25/22, 21:19

    Removed reviewer Simon Schaufelberger.
  8. André Buchmann uploaded patch set 3 V +1 12/08/22, 14:14

  9. core-ci voted on patch set 3 V -1 12/08/22, 14:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34798

  10. André Buchmann uploaded patch set 4 V -1 12/08/22, 14:56

  11. core-ci voted on patch set 4 V +1 12/08/22, 15:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34802

  12. Benni Mack rebased onto patch set 5 V +1 03/24/23, 21:53

  13. core-ci voted on patch set 5 V +1 03/24/23, 22:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39609

  14. Stefan Bürk commented on patch set 5 03/26/23, 20:44

    If this should be really handles as "feature" it needs a feature rst file, per rule. However, not sure if we should handle this as "FEATURE". Would say its more a task if not a bugfix at all. However, beside this there is already another path which tackles the same topic - beside another issue (as bugfix) for the introduced change with 12.0 ... https://review.typo3.org/c/Packages/TYPO3.CMS/+/75867 Maybe we should consolidate that an got more with the other patch ....
  15. Stefan Bürk commented on patch set 5 03/26/23, 20:49

    Reply

    Beside this - I don't get the effort to revert this. If you need "readable and deterministic" it states for kind of hard coded paths, which are evil by design. Bad habit revealed at it's best.
  16. Stefan Bürk commented on patch set 5 03/26/23, 20:58

    Reply

    Forget the link above - the other patch deals with something else.
  17. Benni Mack updated the commit message in patch set 6 V +1 03/27/23, 07:32

  18. core-ci voted on patch set 6 V +1 03/27/23, 07:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39667

  19. Benjamin Kott rebased onto patch set 7 V +1 07/03/23, 16:08

  20. core-ci voted on patch set 7 V +1 07/03/23, 16:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43259

  21. André Buchmann abandoned the change 05/15/24, 15:07