Review main Merged Breaking

75389[!!!][TASK] Remove support for concat/compress of JS+CSS in BE

Benni Mack CR +2 V +2 Hard +187 −178 updated 08/13/22, 12:20

Commit message

This change removes the support for supporting concatenation and
compression of CSS + JS assets in TYPO3 Backend.

This feature was actually introduced back in TYPO3 v4.x because of
limitations of Internet Explorer (max of 31 CSS files per HTML page),
and before the introduction of bundlers + compressors for TYPO3 Core,
as well as HTTP/2 support and optimized caching.

For this reason, all the functionality within PageRenderer and
ResourceCompressor is removed in TYPO3, without any option to
activate this.

TYPO3 already bundles CSS in one single file, and JS is nowadays
loaded with bundlers, and loaders within JS modules in TYPO3 Backend.

For TYPO3 Frontend, this functionality is still available for
the time being.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
    • Christian Kuhn +1
    • Jörg Bösche +1
  • Verified V +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 8

Review log 1520

  1. Benni Mack uploaded patch set 1 08/06/22, 16:38

  2. core-ci voted on patch set 1 V -1 08/06/22, 16:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29908

  3. Benni Mack uploaded patch set 2 08/07/22, 12:47

  4. core-ci voted on patch set 2 V +1 08/07/22, 13:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29914

  5. Benni Mack uploaded patch set 3 08/07/22, 13:16

  6. core-ci voted on patch set 3 V +1 08/07/22, 13:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29917

  7. Jörg Bösche voted on patch set 3 CR +1 08/07/22, 20:32

  8. Simon Schaufelberger updated the commit message in patch set 4 08/07/22, 22:38

  9. Simon Schaufelberger voted on patch set 4 CR +1 08/07/22, 22:43

  10. core-ci voted on patch set 4 V +1 08/07/22, 22:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29929

  11. Markus Klein commented on patch set 4 08/08/22, 08:06

    Can we drop the options in DefaultConfiguration BE|compression etc. as well?

    PageRenderer.php:2458

    Don't we have a constant for this? Shall we introduce one?
  12. Benni Mack commented on patch set 4 08/08/22, 10:41

    Reply

    still used in the PSR-15 middleware to compress your HTML.

    PageRenderer.php:2458 Reply

    A global constant? We only have REQUESTTYPE_FE. We could do a "protected function isFrontend()" but that sounds like a separate change to me (we have a few places in this class with === 'BE' already.
  13. Benni Mack uploaded patch set 5 08/08/22, 10:42

  14. Benni Mack commented on patch set 5 08/08/22, 10:45

    PageRenderer.php:2458 Reply

    Done
  15. core-ci voted on patch set 5 V +1 08/08/22, 10:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29949

  16. Jörg Bösche voted on patch set 5 CR +1 08/08/22, 11:06

  17. Christian Kuhn voted on patch set 5 V +1 CR +1 08/13/22, 07:01

  18. Stefan Bürk voted on patch set 5 V +1 CR +1 08/13/22, 08:44

  19. Benni Mack voted on patch set 5 V +2 CR +2 08/13/22, 12:20

  20. Benni Mack merged patch set 6 08/13/22, 12:20