75389[!!!][TASK] Remove support for concat/compress of JS+CSS in BE
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Stefan Bürk +1
- Christian Kuhn +1
- Jörg Bösche +1
-
Verified V +2 Done
- Benni Mack +2
- Stefan Bürk +1
- Christian Kuhn +1
- core-ci +1 CI
Issues 1
Files 8
- typo3/sysext/backend/Classes/Template/PageRendererBackendSetupTrait.php+0 −4
- typo3/sysext/core/Classes/Page/PageRenderer.php3+93 −75
- typo3/sysext/core/Classes/Resource/ResourceCompressor.php+6 −33
- typo3/sysext/core/Documentation/Changelog/12.0/Breaking-98100-CompressionAndConcatenationOfJavaScriptAndCSSFilesForBackendRemoved.rstnew+57 −0
- typo3/sysext/core/Tests/Unit/Resource/ResourceCompressorIntegrationTest.php+3 −3
- typo3/sysext/core/Tests/Unit/Resource/ResourceCompressorTest.php+1 −63
- typo3/sysext/install/Configuration/ExtensionScanner/Php/ArrayDimensionMatcher.php+20 −0
- typo3/sysext/install/Configuration/ExtensionScanner/Php/MethodCallMatcher.php+7 −0
Review log 1520
-
Benni Mack uploaded patch set 1 08/06/22, 16:38
-
core-ci voted on patch set 1 V -1 08/06/22, 16:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29908
-
Benni Mack uploaded patch set 2 08/07/22, 12:47
-
core-ci voted on patch set 2 V +1 08/07/22, 13:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29914
-
Benni Mack uploaded patch set 3 08/07/22, 13:16
-
core-ci voted on patch set 3 V +1 08/07/22, 13:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29917
-
Jörg Bösche voted on patch set 3 CR +1 08/07/22, 20:32
-
Simon Schaufelberger updated the commit message in patch set 4 08/07/22, 22:38
-
Simon Schaufelberger voted on patch set 4 CR +1 08/07/22, 22:43
-
core-ci voted on patch set 4 V +1 08/07/22, 22:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29929
-
Markus Klein commented on patch set 4 08/08/22, 08:06
Can we drop the options in DefaultConfiguration BE|compression etc. as well?PageRenderer.php:2458Don't we have a constant for this? Shall we introduce one? -
Benni Mack commented on patch set 4 08/08/22, 10:41
Reply
still used in the PSR-15 middleware to compress your HTML.PageRenderer.php:2458ReplyA global constant? We only have REQUESTTYPE_FE. We could do a "protected function isFrontend()" but that sounds like a separate change to me (we have a few places in this class with === 'BE' already. -
Benni Mack uploaded patch set 5 08/08/22, 10:42
-
Benni Mack commented on patch set 5 08/08/22, 10:45
PageRenderer.php:2458ReplyDone -
core-ci voted on patch set 5 V +1 08/08/22, 10:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29949
-
Jörg Bösche voted on patch set 5 CR +1 08/08/22, 11:06
-
Christian Kuhn voted on patch set 5 V +1 CR +1 08/13/22, 07:01
-
Stefan Bürk voted on patch set 5 V +1 CR +1 08/13/22, 08:44
-
Benni Mack voted on patch set 5 V +2 CR +2 08/13/22, 12:20
-
Benni Mack merged patch set 6 08/13/22, 12:20