Review 11.5 Abandoned

75400[BUGFIX] Make file paths absolute in GIFBUILDER

Simon Schaufelberger CR 0 V 0 Hard +221 −42 updated 10/31/24, 14:43

Commit message

In CLI context the full path to the temporary generated file by the
GIFBUILDER can't be resolved. Because of this inconsistency, absolute
file paths are used from now on.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 6

Review log 1214

  1. Simon Schaufelberger uploaded patch set 1 08/09/22, 09:43

  2. Simon Schaufelberger marked it work in progress 08/09/22, 09:47

  3. Simon Schaufelberger wrote 08/09/22, 09:50

    Set private
  4. Simon Schaufelberger wrote 08/09/22, 22:38

    Unset private
  5. Oliver Hader commented on patch set 1 05/02/23, 10:44

    Can we drop this change? If not, please create a version for the `main` branch
  6. Simon Schaufelberger commented on patch set 1 05/06/23, 12:21

    why do you care about this patch? it's in WIP state and it's already in main. I created this patch to composer patch it into a customer installation
  7. Simon Schaufelberger wrote 06/30/23, 02:00

    Removed cc Oliver Hader.
  8. Simon Schaufelberger uploaded patch set 2 06/30/23, 02:28

  9. core-ci voted on patch set 2 V +1 06/30/23, 02:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43130

  10. Simon Schaufelberger uploaded patch set 3 V +1 10/24/23, 11:09

  11. core-ci voted on patch set 3 V +1 10/24/23, 11:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48121

  12. Simon Schaufelberger marked it ready for review 10/24/23, 18:03

  13. Simon Schaufelberger marked it work in progress 10/24/23, 18:03

  14. Benni Mack abandoned the change 10/31/24, 14:43

    I will abandon this change for v11, as we won't merge this into the public repo anymore, free v11.5 support ends today.