75400[BUGFIX] Make file paths absolute in GIFBUILDER
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 6
- typo3/sysext/core/Classes/Imaging/GraphicalFunctions.php+9 −9
- typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php+6 −5
- typo3/sysext/frontend/Classes/ContentObject/ImageContentObject.php+4 −3
- typo3/sysext/frontend/Classes/ContentObject/ImageResourceContentObject.php+3 −1
- typo3/sysext/frontend/Classes/Imaging/GifBuilder.php+16 −15
- typo3/sysext/frontend/Tests/Functional/Imaging/GifBuilderTest.php+183 −9
Review log 1214
-
Simon Schaufelberger uploaded patch set 1 08/09/22, 09:43
-
Simon Schaufelberger marked it work in progress 08/09/22, 09:47
-
Simon Schaufelberger wrote 08/09/22, 09:50
Set private -
Simon Schaufelberger wrote 08/09/22, 22:38
Unset private -
Oliver Hader commented on patch set 1 05/02/23, 10:44
Can we drop this change? If not, please create a version for the `main` branch -
Simon Schaufelberger commented on patch set 1 05/06/23, 12:21
why do you care about this patch? it's in WIP state and it's already in main. I created this patch to composer patch it into a customer installation -
Simon Schaufelberger wrote 06/30/23, 02:00
Removed cc Oliver Hader. -
Simon Schaufelberger uploaded patch set 2 06/30/23, 02:28
-
core-ci voted on patch set 2 V +1 06/30/23, 02:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43130
-
Simon Schaufelberger uploaded patch set 3
V +110/24/23, 11:09 -
core-ci voted on patch set 3 V +1 10/24/23, 11:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48121
-
Simon Schaufelberger marked it ready for review 10/24/23, 18:03
-
Simon Schaufelberger marked it work in progress 10/24/23, 18:03
-
Benni Mack abandoned the change 10/31/24, 14:43
I will abandon this change for v11, as we won't merge this into the public repo anymore, free v11.5 support ends today.