Review main Merged

75401[BUGFIX] Avoid workspace field query for non workspaced table

Stefan Bürk CR +2 V +2 Nightmare +5582 −98 updated 08/12/22, 17:35

Commit message

With #97989 correct workspace overlays in DataMapProcessor
should be used to fix a bug. This introduced a failing default
"where" if a child table is not workspace aware.

The fix itself is straight forward: Query t3ver_wsid field
only if the target table is workspace aware.

On functional test level, a new scenario set is added to
look at details when a parent table like pages or tt_content
is workspace aware, but inline children are not. The new
test setup "test_inline_foreignfield_non_ws" is similar
to "test_inline_foreignfield", just without the frontend
scenarios, which are kinda useless here, at least for now.
They reveal various further inconsistencies we should take
care of with further patches. For now, these tests should
verify the hard "workspace column does not exist" fail
can't happen anymore in the future.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 2

Files 83

Show 63 more files