75406[TASK] Sort table and field list in DB Check module by labels
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Xavier Perseguers +1
-
Verified V +2 Done
- Andreas Kienast +2
- core-ci +1 CI
Issues 1
Files 1
Review log 2638
Show 813 earlier messages
-
Marcin Sągol uploaded patch set 1 08/09/22, 20:55
-
core-ci voted on patch set 1 V +1 08/09/22, 21:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29989
-
Marcin Sągol uploaded patch set 2 08/09/22, 21:06
-
Marcin Sągol updated the commit message in patch set 3 08/09/22, 21:07
-
core-ci voted on patch set 3 V +1 08/09/22, 21:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29991
-
core-ci voted on patch set 2 V +1 08/09/22, 21:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29990
-
Marcin Sągol updated the commit message in patch set 4 08/09/22, 21:24
-
core-ci voted on patch set 4 V +1 08/09/22, 21:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29992
-
Simon Schaufelberger commented on patch set 4 08/09/22, 22:43
TSconfig.rst:171Since you introduce a new setting, I consider this a FEATURE -
Anja Leichsenring commented on patch set 4 08/10/22, 05:39
No amount of 'I want that in v11' does this not make a feature, as already mentioned in Slack. Please adjust the Tag and the releases line accordingly, and add a feature.rst file to the patch, to give the new configuration setting the stage it deserves. -
Marcin Sągol updated the commit message in patch set 5 08/10/22, 07:01
-
core-ci voted on patch set 5 V +1 08/10/22, 07:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29996
-
Tymoteusz Motylewski commented on patch set 5 08/10/22, 07:33
from my pov this should not be made configurable but a default. and then could be made as a bugfix (but not necesarily backported to v11) or do you see any usecase / advantage of having the table names without order?
-
Andreas Kienast commented on patch set 5 08/10/22, 08:23
QueryGenerator.php:2277ReplyThis class is explicitly marked as "internal", so this is no breaking change by our rules. -
Xavier Perseguers commented on patch set 5 09/14/22, 07:07
QueryGenerator.php:2282Looks to me that logically speaking, the handling of an empty table label that you do on line 2295 here after (`$label ?: $tableName`) should better be done here while computing the mapping between table name and its label, so that sorting with `asort` is effectively taken into account in all cases. -
Simon Schaufelberger commented on patch set 5 08/24/23, 15:00
Marcin, can you please update this patch if you still want this to be in the core? -
Marcin Sągol commented on patch set 5 09/19/23, 12:01
Reply Unresolved
Following the described way or make it (sorting) default? -
Simon Schaufelberger commented on patch set 5 09/19/23, 12:59
QueryGenerator.php:2277ReplyDone -
Simon Schaufelberger commented on patch set 5 09/19/23, 13:00
TSconfig.rst:171ReplyDone -
Marcin Sągol uploaded patch set 6
V +111/13/23, 14:10 -
Marcin Sągol updated the commit message in patch set 7 11/13/23, 14:12
-
Marcin Sągol updated the commit message in patch set 8 11/13/23, 14:14
-
Marcin Sągol updated the commit message in patch set 9 11/13/23, 14:18
-
Marcin Sągol updated the commit message in patch set 10 11/13/23, 14:21
-
core-ci voted on patch set 6 V +1 11/13/23, 14:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48851
-
core-ci voted on patch set 7 V +1 11/13/23, 14:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48852
-
core-ci voted on patch set 9 V +1 11/13/23, 14:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48854
-
core-ci voted on patch set 10 V +1 11/13/23, 14:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48857
-
core-ci voted on patch set 8 V +1 11/13/23, 14:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48853
-
Marcin Sągol commented on patch set 10 11/14/23, 08:28
QueryGenerator.php:2282ReplyAck -
Marcin Sągol rebased onto patch set 11
V +101/19/24, 05:32 -
core-ci voted on patch set 11 V +1 01/19/24, 05:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51789
-
Xavier Perseguers updated the commit message in patch set 12
V +101/19/24, 06:05 -
Xavier Perseguers voted on patch set 12 CR +1 01/19/24, 06:07
-
core-ci voted on patch set 12 V +1 01/19/24, 06:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51790
-
Andreas Kienast voted on patch set 12 CR +1 01/19/24, 12:11
-
Andreas Kienast voted on patch set 12 CR +2 V +2 01/19/24, 12:14
-
Andreas Kienast merged patch set 13 01/19/24, 12:22
QueryGenerator.php:2277