Review main Abandoned

75408[BUGFIX] Stop DataMapper from marking core types as relation

David Blatter CR 0 V 0 Easy +2 −1 updated 10/15/24, 10:13

Commit message

Core types should not be marked as relation event though they are classes.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 1216

  1. David Blatter uploaded patch set 1 08/10/22, 10:44

  2. core-ci voted on patch set 1 V +1 08/10/22, 10:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30001

  3. Oliver Klee updated the commit message in patch set 2 08/10/22, 11:28

  4. core-ci voted on patch set 2 V +1 08/10/22, 11:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30004

  5. Moritz Ngo voted on patch set 2 CR +1 08/12/22, 23:20

  6. Simon Schaufelberger commented on patch set 2 08/13/22, 01:16

    Dear "theLine", could you please enter your full name here: https://my.typo3.org so that we know who you are?
  7. Benni Mack voted on patch set 2 CR +1 10/14/22, 10:43

  8. David Blatter uploaded patch set 3 CR +1 V +1 12/15/22, 21:36

  9. core-ci voted on patch set 3 V +1 12/15/22, 21:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35180

  10. Chris Müller commented on patch set 3 12/16/22, 20:31

    Please remove 9.5, as it is ELTS, so now fix from here.
  11. David Blatter updated the commit message in patch set 4 V +1 12/19/22, 09:56

  12. core-ci voted on patch set 4 V +1 12/19/22, 10:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35233

  13. David Blatter commented on patch set 4 12/22/22, 10:10

    Sorry, this was already done by Oliver Klee once, but I accidently repushed my commit.

    Reply

    Done
  14. Benni Mack commented on patch set 4 04/14/23, 10:03

    any update here? As v10.4 will soon be out of our support, we should adapt or abandon this change.
  15. Benni Mack updated the commit message in patch set 5 V +1 05/03/23, 09:45

  16. Benni Mack abandoned the change 10/15/24, 10:13

    Hey David, I will abandon this change due to lack of feedback now. Feel free to repush this change once you get back to it.