Review main Merged

75411[BUGFIX] Rollback changed records if any

Ingo Fabbri CR +2 V +2 Easy +1 −1 updated 03/26/25, 12:49

Commit message

Record History works with various actions,
such as "modified" or "deleted" records, whereas
the fist stores "oldData" which should be considered
when working on history rollbacks.

The exclusive check for "insertsDeletes"
then implicitly expected "oldData" to be present,
which is not always the case.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Benni Mack +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 2229

Show 34 earlier messages
  1. Ingo Fabbri uploaded patch set 1 08/10/22, 11:33

  2. core-ci voted on patch set 1 V +1 08/10/22, 11:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30006

  3. Ingo Fabbri commented on patch set 1 08/10/22, 15:09

    Feel free to add a meaningful commit message.
  4. Moritz Ngo voted on patch set 1 CR +1 08/12/22, 23:22

  1. Benni Mack updated the commit message in patch set 2 CR +1 V +1 04/14/23, 16:56

  2. Benni Mack commented on patch set 2 CR +1 04/14/23, 16:56

    Reply

    Done
  3. core-ci voted on patch set 2 V -1 04/14/23, 17:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40635

  4. Stefan Bürk rebased onto patch set 3 CR +1 V -1 04/14/23, 17:45

  5. core-ci voted on patch set 3 V +1 04/14/23, 17:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40636

  6. Benni Mack updated the commit message in patch set 4 V +1 05/03/23, 09:46

  7. Ingo Fabbri commented on patch set 4 CR +1 08/04/23, 09:29

    BUMP
  8. Ingo Fabbri voted on patch set 4 CR 0 08/04/23, 09:30

  9. Anja Leichsenring rebased onto patch set 5 08/05/23, 07:18

  10. core-ci voted on patch set 5 V +1 08/05/23, 07:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45092

  11. Benni Mack commented on patch set 6 V +1 08/07/23, 08:55

    Published edit on patch set 5.
  12. core-ci voted on patch set 6 V +1 08/07/23, 09:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45171

  13. Oliver Klee commented on patch set 6 08/07/23, 10:29

    This line sounds incomplete to me, and I have trouble understanding it. Should this be "if there are any", or should this be "if any … have …"?
  14. Ingo Fabbri commented on patch set 6 08/07/23, 11:58

  15. Oliver Klee wrote 08/25/24, 10:13

    Removed cc Oliver Klee.
  16. Benni Mack updated the commit message in patch set 7 V +1 10/18/24, 13:46

  17. Soren Malling commented on patch set 7 03/26/25, 11:39

    Tested on 12.4 and can confirm expected behavior with change. This should also be targeted 12.4
  18. Benni Mack rebased onto patch set 8 03/26/25, 11:45

  19. Benni Mack updated the commit message in patch set 9 03/26/25, 11:45

  20. core-ci voted on patch set 8 V +1 03/26/25, 11:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76370

  21. core-ci voted on patch set 9 V +1 03/26/25, 11:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76371

  22. Benni Mack voted on patch set 9 CR +1 V +1 03/26/25, 12:00

  23. Benni Mack commented on patch set 9 03/26/25, 12:02

    Reply

    Done
  24. Andreas Kienast voted on patch set 9 CR +2 V +2 03/26/25, 12:38

  25. Andreas Kienast merged patch set 10 03/26/25, 12:49