Review main Merged

75416[BUGFIX] Align variable name with flexform, template and docs

André Buchmann CR +2 V +2 Easy +30 −1 updated 12/21/22, 15:44

Commit message

The showForgotPasswordLink setting was renamed to showForgotPassword
during the refactoring to fluid templates. It is now also renamed in
the TypoScript setup.

The TypoScript constant name is not changed to keep compatibility.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benni Mack +2
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 1012

  1. André Buchmann uploaded patch set 1 08/11/22, 10:05

  2. core-ci voted on patch set 1 V +1 08/11/22, 10:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30036

  3. Andreas Kienast commented on patch set 1 CR -1 08/12/22, 07:55

    I think renaming the variable (albeit it was wrong previously) is a breaking change as people probably found a way to workaround this. To relax the situation, something like `showForgotPasswordLink < .showForgotPassword` with an Important.rst could be used for v11.
  4. André Buchmann uploaded patch set 2 08/25/22, 19:38

  5. André Buchmann commented on patch set 2 08/25/22, 19:41

    Reply

    yeah, maybe... I think we should introduce the correct variable beside the wrong ohne in TYPO3 11 and remove the wrong in main/12 with a follow up? Added an rst, but im not shure if this is good ;-) Feel free to correct.
  6. core-ci voted on patch set 2 V +1 08/25/22, 19:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30448

  7. André Buchmann commented on patch set 2 12/08/22, 13:08

    Reply

    As there is no more response I think the rst is fine :-)
  8. Andreas Kienast voted on patch set 2 V +1 CR +1 12/21/22, 10:33

  9. Benni Mack voted on patch set 2 V +2 CR +2 12/21/22, 10:34

  10. Benni Mack merged patch set 3 12/21/22, 10:34

  11. Oliver Klee commented on patch set 3 12/21/22, 15:13

    This change seems to have broken the build. (I have no idea why the build for this change itself is not broken, though.) https://git.typo3.org/typo3/CI/cms/-/jobs/1836132
  12. Oliver Klee commented on patch set 3 12/21/22, 15:44

    Reply

    Done