Review main Merged

75419[BUGFIX] Make <typo3-backend-icon> CSS backwards compatible

Benjamin Franzke CR +2 V +2 Normal +118 −112 updated 10/16/24, 06:12

Commit message

* Fix positioning in inline contents.
   Inline icon-alignment is done with the `vertical-align: -22%` hack.
   It was introduced for icons by #69005, reintroduced for the icon
   element in #97876 and was then removed again in #99879
   (possibly because of conflicts with block-usage).

 * Fix evaluation of icon-opacity-disabled, which was ignored because
   a semicolon was missing between the variable declaration and
   `display: inline-block`

 * Avoid unneeded icon-unify redefinition via variants. That's
   only used to hide an implicit condition to shadow size=default.
   But that case can rather be expressed using a fallback in the
   var() expression.

 * Ensure that global CSS properties are taken into account
   by avoiding a redefinition via :host() and using var()
   fallbacks instead.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Andreas Kienast +1
    • Benjamin Kott +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Andreas Kienast +1
    • Benjamin Kott +1
    • core-ci +1 CI

Issues 4

Files 6

Review log 2234

Show 69 earlier messages
  1. Benjamin Franzke uploaded patch set 1 08/11/22, 13:04

  2. core-ci voted on patch set 1 V +1 08/11/22, 13:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30044

  3. Benjamin Franzke commented on patch set 1 08/11/22, 13:15

    icon-element.ts:77

    medium
  4. Benjamin Franzke uploaded patch set 2 V +1 08/15/23, 07:35

  5. Benjamin Franzke uploaded patch set 3 08/15/23, 07:38

  6. Benjamin Franzke commented on patch set 3 08/15/23, 07:38

    icon-element.ts:77 Reply

    Done
  7. core-ci voted on patch set 2 V +1 08/15/23, 07:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45494

  8. core-ci voted on patch set 3 V +1 08/15/23, 07:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45495

  9. Benjamin Franzke uploaded patch set 4 V +1 08/16/23, 09:11

  1. core-ci voted on patch set 4 V +1 08/16/23, 09:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45540

  2. Benjamin Franzke uploaded patch set 5 V +1 08/17/23, 07:00

    Initial-Upload git mv only
  3. Benjamin Franzke uploaded patch set 6 08/17/23, 07:06

  4. core-ci voted on patch set 5 V +1 08/17/23, 07:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45570

  5. core-ci voted on patch set 6 V +1 08/17/23, 07:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45573

  6. Benjamin Franzke commented on patch set 6 08/21/23, 13:06

    Will provide an example that worked in v11 and does not in v12. Marking as WIP until then.
  7. Benjamin Franzke marked it work in progress 08/21/23, 13:06

  8. Benjamin Franzke uploaded patch set 7 V +1 08/27/24, 15:27

  9. core-ci voted on patch set 7 V +1 08/27/24, 15:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64332

  10. Benjamin Franzke uploaded patch set 8 V +1 09/11/24, 09:24

  11. Benjamin Franzke uploaded patch set 9 09/11/24, 09:33

  12. core-ci voted on patch set 8 V -1 09/11/24, 09:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65399

  13. core-ci voted on patch set 9 V -1 09/11/24, 09:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65402

  14. Benjamin Franzke uploaded patch set 10 V -1 09/11/24, 09:50

  15. Oli Bartsch commented on patch set 10 09/11/24, 09:56

    to be?
    unneeded
    an
  16. core-ci voted on patch set 10 V +1 09/11/24, 10:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65409

  17. Benjamin Franzke updated the commit message in patch set 11 V +1 09/11/24, 11:54

  18. Benjamin Franzke commented on patch set 11 09/11/24, 11:54

    Reply

    Done

    Reply

    Done

    Reply

    Done
  19. core-ci voted on patch set 11 V -1 09/11/24, 12:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65430

  20. core-ci voted on patch set 11 V +1 09/11/24, 15:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65430

  21. Benjamin Kott voted on patch set 11 CR +1 V +1 10/02/24, 10:32

  22. Andreas Kienast voted on patch set 11 CR +1 V +1 10/04/24, 06:27

  23. Benjamin Franzke voted on patch set 11 CR +2 V +2 10/04/24, 09:05

  24. Benjamin Franzke merged patch set 12 10/04/24, 09:06

  25. Andreas Kienast commented on patch set 12 10/16/24, 06:12

    icons.ts:29 Unresolved

    Missing ;