75425[FEATURE] Allow icon deprecation in extensions
Commit message
Review
-
Code review CR +2 Done
- Nikita Hovratov +2
- Anja Leichsenring +1
- Stefan Bürk +1
- Christian Kuhn +1
-
Verified V +2 Done
- Nikita Hovratov +2
- Anja Leichsenring +1
- Stefan Bürk +1
- Christian Kuhn +1
- core-ci +1 CI
Issues 1
Files 2
Review log 1519
-
Andreas Kienast uploaded patch set 1 08/12/22, 09:07
-
Andreas Kienast wrote 08/12/22, 09:09
Topic set to icons -
core-ci voted on patch set 1 V +1 08/12/22, 09:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30068
-
Andreas Kienast uploaded patch set 2 08/12/22, 10:10
-
core-ci voted on patch set 2 V +1 08/12/22, 10:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30073
-
Chris Müller commented on patch set 2 08/12/22, 11:58
I also tried "deprecation => true" which works fine. But I think we should not promote this.Feature-98130-AllowDeprecationOfIconsInExtensions.rst:27Perhaps we should write "TYPO3 deprecation log"? -
Andreas Kienast commented on patch set 2 08/12/22, 12:23
Reply
Yep, that's the intentional fallback if all options are omitted. I agree this shouldn't be promoted :-).Feature-98130-AllowDeprecationOfIconsInExtensions.rst:27ReplyAck -
Andreas Kienast uploaded patch set 3 08/12/22, 12:24
-
core-ci voted on patch set 3 V +1 08/12/22, 12:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30089
-
Chris Müller voted on patch set 3 V +1 CR +1 08/12/22, 13:16
-
Anja Leichsenring voted on patch set 3 V +1 CR +1 08/12/22, 19:40
-
Christian Kuhn voted on patch set 3 CR +1 08/12/22, 19:40
-
Christian Kuhn uploaded patch set 4 08/12/22, 19:43
-
Christian Kuhn voted on patch set 4 V +1 CR +1 08/12/22, 19:43
-
Anja Leichsenring voted on patch set 4 V +1 CR +1 08/12/22, 19:44
-
Stefan Bürk voted on patch set 4 V +1 CR +1 08/12/22, 19:44
-
core-ci voted on patch set 4 V +1 08/12/22, 19:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30122
-
Nikita Hovratov voted on patch set 4 V +2 CR +2 08/12/22, 19:50
-
Nikita Hovratov merged patch set 5 08/12/22, 19:50