Review main Merged Breaking

75427[!!!][FEATURE] Set Symfony 6.1 as minimum requirement

Benni Mack CR +2 V +2 Expert +555 −571 updated 08/17/22, 16:09

Commit message

This change raises the used Symfony Components
to at least version Symfony 6.1.

The requirement for "typo3/symfony-psr-event-dispatcher-adapter"
is removed, as this was for support for allowing
symfony4 AND symfony5 with the same TYPO3 major version.

A few important highlights:
* Symfony DI now only accepts objects or null to be
 returned by $container->get('myService')
* Lots of typehints were added, this is mainly an issue
  if extensions extend Symfony classes
* PHP 8.1+ requirements (which we already have in place for TYPO3 v12)

See all features within Symfony 6.1:
* https://symfony.com/blog/category/living-on-the-edge/6.1

Symfony 6 is supported until November 2027 (once we
upgrade to Symfony 6 LTS, which will happen in November 2023)
unlike Symfony 5 LTS which has an EOL on November 2025.

Used commands:

> composer req composer/composer:^2.3.0 -W --dev
> composer remove typo3/symfony-psr-event-dispatcher-adapter
> composer remove --no-update -d typo3/sysext/core \
    typo3/symfony-psr-event-dispatcher-adapter
> composer req --no-update -d typo3/sysext/adminpanel \
    symfony/var-dumper:^6.1
> composer req --no-update -d typo3/sysext/core \
	psr/container:^2.0 \
	symfony/config:^6.1 \
	symfony/console:^6.1 \
	symfony/dependency-injection:^6.1 \
	symfony/event-dispatcher-contracts:^3.1 \
	symfony/expression-language:^6.1 \
	symfony/filesystem:^6.1 \
	symfony/finder:^6.1 \
	symfony/http-foundation:^6.1 \
	symfony/mailer:^6.1 \
	symfony/mime:^6.1 \
	symfony/options-resolver:^6.1 \
	symfony/rate-limiter:^6.1 \
	symfony/routing:^6.1 \
	symfony/yaml:^6.1
> composer req --no-update -d typo3/sysext/extbase \
	symfony/dependency-injection:^6.1 \
	symfony/property-access:^6.1 \
	symfony/property-info:^6.1
> composer req --no-update -d typo3/sysext/fluid \
	symfony/dependency-injection:^6.1
> composer req --no-update -d typo3/sysext/form \
	symfony/expression-language:^6.1
> composer req --no-update -d typo3/sysext/install \
	symfony/finder:^6.1 \
	symfony/http-foundation:^6.1
> composer req --no-update -d typo3/sysext/redirects \
    symfony/console:^6.1
> composer req -W \
	psr/container:^2.0 \
	symfony/config:^6.1 \
	symfony/console:^6.1 \
	symfony/dependency-injection:^6.1 \
	symfony/event-dispatcher-contracts:^3.1 \
	symfony/expression-language:^6.1 \
	symfony/filesystem:^6.1 \
	symfony/finder:^6.1 \
	symfony/http-foundation:^6.1 \
	symfony/mailer:^6.1 \
	symfony/mime:^6.1 \
	symfony/options-resolver:^6.1 \
	symfony/property-access:^6.1 \
	symfony/property-info:^6.1 \
	symfony/rate-limiter:^6.1 \
	symfony/routing:^6.1 \
	symfony/var-dumper:^6.1 \
	symfony/yaml:^6.1

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 49

Show 29 more files