Review main Merged

75433[TASK] Switch to dart-sass

Nikita Hovratov CR +2 V +2 Hard +140 −613 updated 08/12/22, 19:13

Commit message

node-sass respectively LibSass is deprecated as stated in
https://www.npmjs.com/package/node-sass

Since we use Bootstrap v5 since TYPO3 v11, which itself compiles with
dart-sass, the native JavaScript based sass solution, we can finally
also make the switch. This is also possible, as FontAwesome is now
dropped from the core.

The sass-migrator was used here to migrate the majority of division
operators to math.div or inverse it to a multiplication.
See: https://sass-lang.com/documentation/cli/migrator

Used commands:

> yarn remove node-sass
> yarn add sass -D
> sass-migrator division **/*.scss
> Build/Scripts/runTests.sh -s buildCss

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 33