Review main Merged

75436[BUGFIX] Restore module menu collapse behaviour

Stefan Bürk CR +2 V +2 Easy +15 −2 updated 08/14/22, 23:35

Commit message

With the removal of the Font Awesome icon provider in #98089 the
corresponding scss/css styling definition for the module name
has been removed. This made it impossible to fully collapse the
module menu to icons and to a smaller size.

Bootstrap 5 replaced `.sr-only` with `.visually-hidden`. However,
this does not work for the module menu as the menu entry names
are hidden in expanded mode, thus making this a non-usable
option.
See: https://getbootstrap.com/docs/5.0/migration/#helpers
and: https://getbootstrap.com/docs/5.0/helpers/visually-hidden/

This patch re-adds scss/css styling directly for the module
menu without using the `@sr-only` or the new `.visually-hidden`
definition from bootstrap to restore the module menu collapse
behaviour.

Used commands:

> Build/Scripts/runTests.sh -s clean
> Build/Scripts/runTests.sh -s buildCss

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 2

Files 3