Review main Merged

75443[BUGFIX] Always load label for edit notification

Andreas Kienast CR +2 V +2 Easy +16 −0 updated 08/19/22, 09:32

Commit message

If a record is edited via single field mode (aka "columnsOnly"), the
label field as defined via TCA may be missing, rendering "[No title]" in
the notification message.

Before compiling the notification message, it is now checked whether the
label exists already. If not, the label of the record is fetched from
the database, if such label field is configured via TCA at all.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Stefan Bürk +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Stefan Bürk +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1317

  1. Andreas Kienast uploaded patch set 1 08/14/22, 09:58

  2. core-ci voted on patch set 1 V +1 08/14/22, 10:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30161

  3. Thomas Löffler voted on patch set 1 CR +1 08/14/22, 10:21

  4. Riccardo De Contardi commented on patch set 1 V +1 08/14/22, 13:23

    Verified as described on https://forge.typo3.org/issues/98142
  5. Christian Kuhn commented on patch set 1 08/17/22, 09:26

    EditDocumentController.php:659

    we may need to include label_alt fields, too?
  6. Andreas Kienast commented on patch set 1 08/17/22, 12:08

    EditDocumentController.php:659 Reply

    Ack
  7. Andreas Kienast uploaded patch set 2 08/17/22, 12:35

  8. core-ci voted on patch set 2 V +1 08/17/22, 12:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30235

  9. Christian Kuhn uploaded patch set 3 08/19/22, 08:35

  10. Christian Kuhn voted on patch set 3 V +1 CR +1 08/19/22, 08:36

  11. core-ci voted on patch set 3 V -1 08/19/22, 08:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30295

  12. Andreas Kienast rebased onto patch set 4 08/19/22, 09:15

  13. core-ci voted on patch set 4 V +1 08/19/22, 09:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30301

  14. Christian Kuhn voted on patch set 4 V +1 CR +1 08/19/22, 09:26

  15. Stefan Bürk voted on patch set 4 V +1 CR +1 08/19/22, 09:26

  16. Andreas Kienast voted on patch set 4 V +2 CR +2 08/19/22, 09:32

  17. Andreas Kienast merged patch set 5 08/19/22, 09:32