Review main Merged

75448[BUGFIX] Prevent warning when FlexForm is empty in PHP8

Torben Hansen CR +2 V +2 Easy +1 −1 updated 08/17/22, 09:01

Commit message

When a FlexForm has an empty data structure, a warning is thrown
in PHP8, because it is not checked in FlexFormNoTabsContainer if
the resolved sheet name actually exists as key in the
flexFormRowData array.

This patch uses the null coalescing operator to fix the problem.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 911

  1. Torben Hansen uploaded patch set 1 08/15/22, 13:46

  2. core-ci voted on patch set 1 V +1 08/15/22, 13:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30178

  3. Oliver Klee commented on patch set 1 08/15/22, 14:33

    FlexFormNoTabsContainer.php:53

    Wouldn't changing the operator to ?? suffice?
  4. Torben Hansen uploaded patch set 2 08/15/22, 17:18

  5. Torben Hansen commented on patch set 2 08/15/22, 17:20

    FlexFormNoTabsContainer.php:53 Reply

    Yes, you are totally right here. I updated the patch to use the null coalescing operator instead.
  6. core-ci voted on patch set 2 V +1 08/15/22, 17:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30179

  7. Oliver Klee voted on patch set 2 CR +1 08/15/22, 17:35

  8. Christian Kuhn voted on patch set 2 V +1 CR +1 08/17/22, 07:31

  9. Benni Mack voted on patch set 2 V +1 CR +1 08/17/22, 09:00

  10. Christian Kuhn voted on patch set 2 V +2 CR +2 08/17/22, 09:01

  11. Christian Kuhn merged patch set 3 08/17/22, 09:01