75486[FEATURE] Introduce Schema API for TCA
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oli Bartsch +1
- Christian Kuhn +1
- Oliver Hader +1
-
Verified V +2 Done
- Benni Mack +2
- Oli Bartsch +1
- Christian Kuhn +1
- core-ci +1 CI
Issues 1
Files 93
- typo3/sysext/core/Classes/Core/BootService.php+6 −0
- typo3/sysext/core/Classes/Core/Bootstrap.php2+2 −0
- typo3/sysext/core/Classes/DataHandling/DataHandler.php+478 −363
- typo3/sysext/core/Classes/Domain/RawRecord.php+8 −0
- typo3/sysext/core/Classes/Domain/RecordFactory.php+73 −145
- typo3/sysext/core/Classes/Schema/Capability/FieldCapability.phpnew+47 −0
- typo3/sysext/core/Classes/Schema/Capability/LabelCapability.phpnew+64 −0
- typo3/sysext/core/Classes/Schema/Capability/LanguageAwareSchemaCapability.phpnew+68 −0
- typo3/sysext/core/Classes/Schema/Capability/RootLevelCapability.phpnew+64 −0
- typo3/sysext/core/Classes/Schema/Capability/ScalarCapability.phpnew+41 −0
- typo3/sysext/core/Classes/Schema/Capability/SchemaCapabilityInterface.phpnew+25 −0
- typo3/sysext/core/Classes/Schema/Capability/SystemInternalFieldCapability.phpnew+39 −0
- typo3/sysext/core/Classes/Schema/Capability/TcaSchemaCapability.phpnew+107 −0
- typo3/sysext/core/Classes/Schema/Exception/FieldTypeNotAvailableException.phpnew+22 −0
- typo3/sysext/core/Classes/Schema/Exception/UndefinedFieldException.phpnew+22 −0
- typo3/sysext/core/Classes/Schema/Exception/UndefinedSchemaException.phpnew+22 −0
- typo3/sysext/core/Classes/Schema/Field/AbstractFieldType.php3new+88 −0
- typo3/sysext/core/Classes/Schema/Field/CategoryFieldType.phpnew+52 −0
- typo3/sysext/core/Classes/Schema/Field/CheckboxFieldType.phpnew+34 −0
- typo3/sysext/core/Classes/Schema/Field/ColorFieldType.phpnew+34 −0
Show 73 more files
- typo3/sysext/core/Classes/Schema/Field/DateTimeFieldType.phpnew+44 −0
- typo3/sysext/core/Classes/Schema/Field/EmailFieldType.phpnew+34 −0
- typo3/sysext/core/Classes/Schema/Field/FieldCollection.phpnew+69 −0
- typo3/sysext/core/Classes/Schema/Field/FieldTranslationBehaviour.phpnew+58 −0
- typo3/sysext/core/Classes/Schema/Field/FieldTypeInterface.php2new+41 −0
- typo3/sysext/core/Classes/Schema/Field/FileFieldType.phpnew+55 −0
- typo3/sysext/core/Classes/Schema/Field/FlexFormFieldType.phpnew+39 −0
- typo3/sysext/core/Classes/Schema/Field/FolderFieldType.phpnew+34 −0
- typo3/sysext/core/Classes/Schema/Field/GroupFieldType.phpnew+52 −0
- typo3/sysext/core/Classes/Schema/Field/ImageManipulationFieldType.phpnew+34 −0
- typo3/sysext/core/Classes/Schema/Field/InlineFieldType.phpnew+59 −0
- typo3/sysext/core/Classes/Schema/Field/InputFieldType.phpnew+34 −0
- typo3/sysext/core/Classes/Schema/Field/JsonFieldType.phpnew+34 −0
- typo3/sysext/core/Classes/Schema/Field/LanguageFieldType.phpnew+34 −0
- typo3/sysext/core/Classes/Schema/Field/LinkFieldType.phpnew+39 −0
- typo3/sysext/core/Classes/Schema/Field/NoneFieldType.phpnew+34 −0
- typo3/sysext/core/Classes/Schema/Field/NumberFieldType.phpnew+39 −0
- typo3/sysext/core/Classes/Schema/Field/PassthroughFieldType.phpnew+34 −0
- typo3/sysext/core/Classes/Schema/Field/PasswordFieldType.phpnew+39 −0
- typo3/sysext/core/Classes/Schema/Field/RadioFieldType.phpnew+34 −0
- typo3/sysext/core/Classes/Schema/Field/RelationalFieldTypeInterface.phpnew+36 −0
- typo3/sysext/core/Classes/Schema/Field/SelectRelationFieldType.phpnew+54 −0
- typo3/sysext/core/Classes/Schema/Field/SlugFieldType.phpnew+34 −0
- typo3/sysext/core/Classes/Schema/Field/StaticSelectFieldType.phpnew+36 −0
- typo3/sysext/core/Classes/Schema/Field/TextFieldType.phpnew+39 −0
- typo3/sysext/core/Classes/Schema/Field/UserFieldType.phpnew+34 −0
- typo3/sysext/core/Classes/Schema/Field/UuidFieldType.phpnew+34 −0
- typo3/sysext/core/Classes/Schema/Struct/FlexSectionContainer.phpnew+57 −0
- typo3/sysext/core/Classes/Schema/Struct/FlexSheet.php2new+60 −0
- typo3/sysext/core/Classes/Schema/ActiveRelation.php5new+51 −0
- typo3/sysext/core/Classes/Schema/FieldTypeFactory.phpnew+173 −0
- typo3/sysext/core/Classes/Schema/FlexFormSchema.phpnew+47 −0
- typo3/sysext/core/Classes/Schema/FlexFormSchemaFactory.phpnew+114 −0
- typo3/sysext/core/Classes/Schema/PassiveRelation.phpnew+52 −0
- typo3/sysext/core/Classes/Schema/RelationMap.phpnew+158 −0
- typo3/sysext/core/Classes/Schema/RelationMapBuilder.php2new+84 −0
- typo3/sysext/core/Classes/Schema/RelationshipType.php2new+63 −0
- typo3/sysext/core/Classes/Schema/SchemaCollection.phpnew+74 −0
- typo3/sysext/core/Classes/Schema/SchemaInterface.php2new+30 −0
- typo3/sysext/core/Classes/Schema/TcaSchema.php2new+250 −0
- typo3/sysext/core/Classes/Schema/TcaSchemaFactory.php9new+300 −0
- typo3/sysext/core/Documentation/Changelog/13.2/Feature-104002-SchemaAPI.rst4new+181 −0
- typo3/sysext/core/Tests/Functional/DataHandling/DataHandler/DefaultValuesTest.php+4 −0
- typo3/sysext/core/Tests/Functional/DataHandling/DataHandler/GetUniqueTranslationTest.php+9 −0
- typo3/sysext/core/Tests/Functional/DataHandling/Regular/Hooks/PagesTsConfigGuardTest.php+1 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/CategoryOneToOne/AbstractActionTestCase.php+3 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/FAL/AbstractActionTestCase.php+2 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/Group/AbstractActionTestCase.php+5 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/IrreCsv/AbstractActionTestCase.php+22 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/IrreCsv/AbstractActionWorkspacesTestCase.php+4 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/IrreForeignField/AbstractActionTestCase.php+17 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/IrreForeignFieldNonWs/AbstractActionTestCase.php+17 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/ManyToMany/AbstractActionTestCase.php+7 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/Regular/Modify/ActionTest.php+2 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/Regular/AbstractActionTestCase.php+6 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/RegularFreeMode/AbstractActionTestCase.php+2 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/RegularLocalize/AbstractActionTestCase.php+12 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/Select/AbstractActionTestCase.php+3 −0
- typo3/sysext/core/Tests/Functional/Domain/RecordFactoryTest.php+7 −5
- typo3/sysext/core/Tests/Functional/Schema/RelationMapBuilderTest.phpnew+79 −0
- typo3/sysext/core/Tests/Functional/Schema/TcaSchemaTest.phpnew+101 −0
- typo3/sysext/core/Tests/Unit/DataHandling/DataHandlerTest.php+21 −0
- typo3/sysext/core/Tests/Unit/Domain/RecordFactoryTest.php+15 −356
- typo3/sysext/core/Tests/Unit/Schema/Field/FieldTypeFactoryTest.phpnew+38 −0
- typo3/sysext/core/Tests/Unit/Schema/RelationshipTypeTest.phpnew+81 −0
- typo3/sysext/core/Tests/Unit/Schema/SchemaCollectionTest.phpnew+60 −0
- typo3/sysext/core/Tests/Unit/Schema/TcaSchemaFactoryTest.phpnew+427 −0
- typo3/sysext/styleguide/Configuration/TCA/tx_styleguide_inline_usecombinationbox_child.php+14 −0
- typo3/sysext/styleguide/Configuration/TCA/tx_styleguide_inline_usecombinationbox_mm.php+14 −1
- typo3/sysext/styleguide/Configuration/TCA/tx_styleguide_inline_usecombinationgroup_child.php+15 −0
- typo3/sysext/styleguide/Configuration/TCA/tx_styleguide_inline_usecombinationgroup_mm.php+15 −0
- typo3/sysext/styleguide/Configuration/TCA/tx_styleguide_inline_usecombination_child.php+14 −1
- typo3/sysext/styleguide/Configuration/TCA/tx_styleguide_inline_usecombination_mm.php+14 −2
Review log 133229
Show 115204 earlier messages
-
Benni Mack uploaded patch set 1 08/17/22, 21:05
-
core-ci voted on patch set 1 V -1 08/17/22, 21:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30252
-
Benni Mack uploaded patch set 2 08/18/22, 12:05
-
core-ci voted on patch set 2 V -1 08/18/22, 12:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30268
-
Nikita Hovratov commented on patch set 2 08/18/22, 12:15
We could further objectify the configuration part like I did here: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74264 -
Benni Mack commented on patch set 2 08/18/22, 12:18
Reply
Yes. Thought about that. However, I think we should first nail the Schema (that is: let's identify the important points for a field) and then build composition objects for the configuration for e.g. FormEngine, where we need exactly this information. The puzzle is almost complete now: * RelationalFields (select, group, irre, category) are missing * ColumnsOverrides is missing Once I have solved this, I would like to apply this to Page Module Content Element Preview rendering, and see how this works out, before we dive into FormEngine, I'd say. -
Benni Mack uploaded patch set 3 08/18/22, 13:16
-
core-ci voted on patch set 3 V -1 08/18/22, 13:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30271
-
Benni Mack uploaded patch set 4 08/18/22, 13:26
-
core-ci voted on patch set 4 V -1 08/18/22, 13:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30272
-
Nikita Hovratov uploaded patch set 5 08/26/22, 18:23
-
core-ci voted on patch set 5 V -1 08/26/22, 18:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30473
-
Nikita Hovratov uploaded patch set 6 08/26/22, 19:22
-
core-ci voted on patch set 6 V -1 08/26/22, 19:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30474
-
Nikita Hovratov uploaded patch set 7 08/26/22, 20:34
-
core-ci voted on patch set 7 V -1 08/26/22, 20:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30475
-
Nikita Hovratov uploaded patch set 8 08/26/22, 22:02
-
core-ci voted on patch set 8 V -1 08/26/22, 22:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30476
-
Nikita Hovratov commented on patch set 8 08/26/22, 22:30
We now need to rethink all functional tests, which modify TCA on the fly. This isn't possible anymore, as TCA is locked after the initial compilation. -
Nikita Hovratov uploaded patch set 9 08/27/22, 00:54
-
core-ci voted on patch set 9 V +1 08/27/22, 01:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30477
-
Nikita Hovratov uploaded patch set 10 08/27/22, 08:45
-
core-ci voted on patch set 10 V +1 08/27/22, 08:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30481
-
Nikita Hovratov uploaded patch set 11 08/27/22, 11:22
-
core-ci voted on patch set 11 V -1 08/27/22, 11:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30482
-
Nikita Hovratov uploaded patch set 12 08/27/22, 11:43
-
core-ci voted on patch set 12 V -1 08/27/22, 11:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30483
-
Nikita Hovratov uploaded patch set 13 08/27/22, 11:52
-
core-ci voted on patch set 13 V -1 08/27/22, 12:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30484
-
Oliver Klee commented on patch set 13 08/27/22, 12:03
TcaSchemaInterface.php:31This change doesn't look right to me. Should that possibly be SchemaCollection<TcaSchema>, or am I missing something here? -
Nikita Hovratov uploaded patch set 14 08/27/22, 12:10
-
core-ci voted on patch set 14 V +1 08/27/22, 12:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30485
-
Nikita Hovratov commented on patch set 14 08/27/22, 12:21
TcaSchemaInterface.php:31ReplyHey Oliver, this patch is still wip. I added it, so phpstorm can autocomplete methods for me. SchemaCollection<TcaSchema> will not work sadly. This will probably be removed / improved afterwards. -
Nikita Hovratov commented on patch set 14 08/27/22, 12:21
TcaSchemaInterface.php:31ReplyDone -
Nikita Hovratov uploaded patch set 15 08/27/22, 12:37
-
Oliver Klee commented on patch set 14 08/27/22, 12:38
TcaSchemaInterface.php:31ReplyMaybe we can use Generics for SchemaCollection for this. I you would like to have help with this, please let me know. -
core-ci voted on patch set 15 V -1 08/27/22, 12:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30487
-
Nikita Hovratov uploaded patch set 16 08/27/22, 14:52
-
core-ci voted on patch set 16 V -1 08/27/22, 14:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30491
-
Nikita Hovratov uploaded patch set 17 08/27/22, 15:09
-
core-ci voted on patch set 17 V -1 08/27/22, 15:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30492
-
Nikita Hovratov uploaded patch set 18 08/27/22, 15:24
-
core-ci voted on patch set 18 V -1 08/27/22, 15:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30493
-
Nikita Hovratov uploaded patch set 19 08/27/22, 15:55
-
Nikita Hovratov commented on patch set 19 08/27/22, 15:58
TcaSchemaInterface.php:31ReplyThanks, maybe at a later stage? Don't want to burden you with work, if this gets discarded anyway. As of now, there is only one Schema. I don't know if Benni planned to add more. -
Oliver Klee commented on patch set 19 08/27/22, 16:02
TcaSchemaInterface.php:31ReplyJust let me know when I should have a look. (In the current state, the annotation is not correct, so I would prefer this change to not get merged with the current annotation.) -
core-ci voted on patch set 19 V -1 08/27/22, 16:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30494
-
Nikita Hovratov uploaded patch set 20 08/27/22, 16:25
-
core-ci voted on patch set 20 V +1 08/27/22, 16:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30495
-
Nikita Hovratov uploaded patch set 21 08/28/22, 18:00
-
core-ci voted on patch set 21 V +1 08/28/22, 18:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30505
-
Nikita Hovratov uploaded patch set 22 08/28/22, 18:20
-
core-ci voted on patch set 22 V +1 08/28/22, 18:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30506
-
Nikita Hovratov uploaded patch set 23 08/28/22, 18:41
-
core-ci voted on patch set 23 V -1 08/28/22, 18:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30507
-
Nikita Hovratov uploaded patch set 24 08/28/22, 18:55
-
core-ci voted on patch set 24 V +1 08/28/22, 19:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30508
-
Nikita Hovratov uploaded patch set 25 08/28/22, 19:10
-
core-ci voted on patch set 25 V +1 08/28/22, 19:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30509
-
Nikita Hovratov uploaded patch set 26 08/28/22, 19:24
-
core-ci voted on patch set 26 V +1 08/28/22, 19:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30510
-
Nikita Hovratov uploaded patch set 27 08/29/22, 08:37
-
core-ci voted on patch set 27 V +1 08/29/22, 08:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30518
-
Nikita Hovratov uploaded patch set 28 08/29/22, 15:14
-
core-ci voted on patch set 28 V +1 08/29/22, 15:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30521
-
Nikita Hovratov uploaded patch set 29 08/29/22, 16:15
-
core-ci voted on patch set 29 V -1 08/29/22, 16:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30523
-
Nikita Hovratov uploaded patch set 30 08/29/22, 16:53
-
core-ci voted on patch set 30 V +1 08/29/22, 17:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30526
-
Nikita Hovratov uploaded patch set 31 08/30/22, 07:56
-
Nikita Hovratov uploaded patch set 32 08/30/22, 08:00
-
core-ci voted on patch set 31 V +1 08/30/22, 08:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30530
-
core-ci voted on patch set 32 V +1 08/30/22, 08:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30531
-
Nikita Hovratov uploaded patch set 33 08/30/22, 16:32
-
core-ci voted on patch set 33 V +1 08/30/22, 16:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30547
-
Nikita Hovratov uploaded patch set 34 08/30/22, 16:43
-
core-ci voted on patch set 34 V +1 08/30/22, 16:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30548
-
Nikita Hovratov uploaded patch set 35 08/30/22, 16:58
-
core-ci voted on patch set 35 V +1 08/30/22, 17:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30549
-
Nikita Hovratov uploaded patch set 36 08/30/22, 17:55
-
core-ci voted on patch set 36 V -1 08/30/22, 18:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30550
-
Nikita Hovratov uploaded patch set 37 08/30/22, 18:17
-
core-ci voted on patch set 37 V +1 08/30/22, 18:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30551
-
Nikita Hovratov uploaded patch set 38 08/30/22, 18:39
-
core-ci voted on patch set 38 V +1 08/30/22, 18:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30552
-
Nikita Hovratov uploaded patch set 39 08/31/22, 10:33
-
core-ci voted on patch set 39 V +1 08/31/22, 10:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30556
-
Nikita Hovratov uploaded patch set 40 08/31/22, 10:57
-
core-ci voted on patch set 40 V -1 08/31/22, 11:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30557
-
Nikita Hovratov uploaded patch set 41 08/31/22, 12:05
-
core-ci voted on patch set 41 V +1 08/31/22, 12:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30560
-
Nikita Hovratov uploaded patch set 42 08/31/22, 12:29
-
core-ci voted on patch set 42 V +1 08/31/22, 12:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30561
-
Nikita Hovratov uploaded patch set 43 09/01/22, 09:32
-
core-ci voted on patch set 43 V -1 09/01/22, 09:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30575
-
Nikita Hovratov uploaded patch set 44 09/01/22, 09:47
-
core-ci voted on patch set 44 V +1 09/01/22, 09:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30576
-
Nikita Hovratov uploaded patch set 45 09/01/22, 10:06
-
core-ci voted on patch set 45 V +1 09/01/22, 10:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30577
-
Nikita Hovratov uploaded patch set 46 09/01/22, 10:17
-
core-ci voted on patch set 46 V -1 09/01/22, 10:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30578
-
Nikita Hovratov uploaded patch set 47 09/01/22, 10:32
-
core-ci voted on patch set 47 V +1 09/01/22, 10:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30579
-
Benni Mack commented on patch set 47 09/05/22, 14:41
AbstractFieldType.php:116we should use getTranslationBehaviour instead. -
Nikita Hovratov commented on patch set 47 09/05/22, 15:29
AbstractFieldType.php:116ReplyThe problem is, that it's possible to mix "allowLanguageSynchronisation" and "l10n_mode", so we can't return only translationBehaviour, can we? -
Benni Mack uploaded patch set 48 09/06/22, 17:02
-
core-ci voted on patch set 48 V -1 09/06/22, 17:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30657
-
Benni Mack uploaded patch set 49 09/07/22, 10:40
-
core-ci voted on patch set 49 V -1 09/07/22, 10:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30731
-
Benni Mack uploaded patch set 50 09/07/22, 12:32
-
core-ci voted on patch set 50 V -1 09/07/22, 12:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30750
-
Benni Mack uploaded patch set 51 09/07/22, 13:13
-
core-ci voted on patch set 51 V -1 09/07/22, 13:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30751
-
Benni Mack uploaded patch set 52 09/07/22, 14:32
-
core-ci voted on patch set 52 V -1 09/07/22, 14:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30757
-
Benni Mack uploaded patch set 53 09/07/22, 15:00
-
Benni Mack uploaded patch set 54 09/07/22, 15:08
-
core-ci voted on patch set 53 V -1 09/07/22, 15:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30760
-
core-ci voted on patch set 54 V -1 09/07/22, 15:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30762
-
Benni Mack uploaded patch set 55 09/07/22, 17:44
-
core-ci voted on patch set 55 V -1 09/07/22, 17:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30775
-
Benni Mack uploaded patch set 56 09/07/22, 19:17
-
core-ci voted on patch set 56 V -1 09/07/22, 19:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30779
-
Benni Mack uploaded patch set 57 09/07/22, 19:40
-
core-ci voted on patch set 57 V -1 09/07/22, 19:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30781
-
Benni Mack uploaded patch set 58 09/07/22, 20:04
-
Benni Mack uploaded patch set 59 09/07/22, 20:53
-
core-ci voted on patch set 59 V -1 09/07/22, 21:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30784
-
Benni Mack uploaded patch set 60 09/08/22, 09:20
-
core-ci voted on patch set 60 V -1 09/08/22, 09:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30798
-
Benni Mack uploaded patch set 61 09/08/22, 10:40
-
core-ci voted on patch set 61 V -1 09/08/22, 10:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30803
-
Benni Mack uploaded patch set 62 09/08/22, 11:49
-
core-ci voted on patch set 62 V -1 09/08/22, 12:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30811
-
Benni Mack uploaded patch set 63 09/08/22, 12:17
-
core-ci voted on patch set 63 V +1 09/08/22, 12:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30813
-
Benni Mack uploaded patch set 64 09/08/22, 12:59
-
core-ci voted on patch set 64 V -1 09/08/22, 13:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30817
-
Benni Mack uploaded patch set 65 09/08/22, 13:52
-
core-ci voted on patch set 65 V -1 09/08/22, 14:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30821
-
Benni Mack rebased onto patch set 66 09/08/22, 17:14
-
core-ci voted on patch set 66 V -1 09/08/22, 17:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30852
-
Benni Mack commented on patch set 66 09/09/22, 10:12
Feedback from Susi: - Use Constants / Enum for built-in Capabilities - Use getcapability() with nullable to make usages easier to understand in favor of "isLanguageAware" and "isWorkspaceAware" to be fully consistent -
Benni Mack uploaded patch set 67 10/17/22, 10:48
-
core-ci voted on patch set 67 V -1 10/17/22, 11:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32385
-
Benni Mack uploaded patch set 68 10/20/22, 19:13
-
core-ci voted on patch set 68 V -1 10/20/22, 19:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32530
-
Nikita Hovratov commented on patch set 68 10/21/22, 13:07
@benni Did you delete SchemaCapability.php by mistake in the last patchset? Looked to me like a rebase only. -
Benni Mack commented on patch set 68 10/21/22, 14:18
Reply
yes, I think it's not suitable for the API right now. Will stick to the approach right now, and "just" add the relational part to it. -
Benni Mack uploaded patch set 69
V -112/06/22, 15:40 -
core-ci voted on patch set 69 V -1 12/06/22, 15:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34725
-
Benni Mack uploaded patch set 70
V -101/10/23, 09:52 -
core-ci voted on patch set 70 V -1 01/10/23, 09:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35638
-
Benni Mack uploaded patch set 71
V -101/10/23, 10:29 -
core-ci voted on patch set 71 V +1 01/10/23, 10:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35640
-
Benni Mack rebased onto patch set 72
V +101/18/23, 21:35 -
core-ci voted on patch set 72 V +1 01/18/23, 21:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36155
-
Benni Mack marked it work in progress 03/24/23, 11:45
-
Andreas Kienast commented on patch set 72 06/10/24, 08:51
TcaSchema.php:114The lists of capabilities here and in `getCapability()` look huge. Perhaps we can have some kind of an capability map that is filled. Also, the capability identifiers could be actual enums. -
Benni Mack uploaded patch set 73
V +106/10/24, 21:02 -
core-ci voted on patch set 73 V -1 06/10/24, 21:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59078
-
Benni Mack uploaded patch set 74
V -106/11/24, 14:23 -
core-ci voted on patch set 74 V -1 06/11/24, 14:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59200
-
Benni Mack uploaded patch set 75
V -106/11/24, 15:06 -
core-ci voted on patch set 75 V -1 06/11/24, 15:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59205
-
Benni Mack uploaded patch set 76
V -106/11/24, 19:27 -
core-ci voted on patch set 76 V -1 06/11/24, 19:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59243
-
Benni Mack uploaded patch set 77
V -106/12/24, 09:34 -
core-ci voted on patch set 77 V -1 06/12/24, 10:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59299
-
Benni Mack uploaded patch set 78
V -106/12/24, 13:23 -
core-ci voted on patch set 78 V -1 06/12/24, 13:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59327
-
Benni Mack uploaded patch set 79
V -106/12/24, 19:20 -
Benni Mack marked it ready for review 06/12/24, 19:21
-
Benni Mack commented on patch set 79 06/12/24, 19:21
TcaSchema.php:114ReplyDone -
core-ci voted on patch set 79 V -1 06/12/24, 19:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59363
-
Benni Mack uploaded patch set 80
V -106/12/24, 19:45 -
core-ci voted on patch set 80 V -1 06/12/24, 19:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59367
-
Nikita Hovratov commented on patch set 80 06/12/24, 20:10
RelationshipType.php:49or "allowed" for type group. -
Benni Mack uploaded patch set 81
V -106/13/24, 06:40 -
core-ci voted on patch set 81 V -1 06/13/24, 06:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59402
-
Benni Mack uploaded patch set 82
V -106/13/24, 07:29 -
core-ci voted on patch set 82 V +1 06/13/24, 07:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59413
-
Benni Mack uploaded patch set 83
V +106/13/24, 09:09 -
core-ci voted on patch set 83 V -1 06/13/24, 09:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59437
-
Nikita Hovratov commented on patch set 83 06/13/24, 09:38
TcaSchemaFactory.php:296parenthesis missing around the second part. -
Benni Mack uploaded patch set 84
V -106/13/24, 10:46 -
Oliver Klee wrote 06/13/24, 10:46
Removed cc Oliver Klee. -
core-ci voted on patch set 84 V -1 06/13/24, 10:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59463
-
Benni Mack uploaded patch set 85
V -106/13/24, 12:54 -
Benni Mack commented on patch set 85 06/13/24, 12:56
AbstractFieldType.php:116Replycurrently, Schema API does not handle allowLanguageSynchronization. I left it out for the time being, as this option is only evaluated in 2 places in TYPO3 Core.RelationshipType.php:49ReplyDoneTcaSchemaFactory.php:296ReplyDone -
core-ci voted on patch set 85 V -1 06/13/24, 13:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59486
-
Christian Kuhn commented on patch set 84 06/13/24, 13:48
Feature-104002-SchemaAPI.rst:69i still don't really understand the difference ... need to think about and let it sink in ...Feature-104002-SchemaAPI.rst:93skip. heavily internal. ext authors must never do this and core should get rid of it. -
Benni Mack uploaded patch set 86
V -106/13/24, 15:08 -
core-ci voted on patch set 86 V +1 06/13/24, 15:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59505
-
Benjamin Franzke uploaded patch set 87
V +106/13/24, 19:00 -
core-ci voted on patch set 87 V -1 06/13/24, 19:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59535
-
Benni Mack uploaded patch set 88
V -106/14/24, 07:14 -
core-ci voted on patch set 88 V +1 06/14/24, 07:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59573
-
Oliver Hader commented on patch set 88 06/26/24, 08:14
ActiveRelation.php:28Shall we use public properties instead and drop the getters?TcaSchemaInterface.php:47I'm not sure, where `string` should be supported here in the interface...TcaSchemaInterface.php:48Hm, hm, hm... pretty hard-coded inference list -
Oliver Hader uploaded patch set 89
V +106/26/24, 08:15 -
core-ci voted on patch set 89 V -1 06/26/24, 08:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60357
-
Oliver Hader commented on patch set 89 06/26/24, 09:51
The (new) failing tests are related to `tt_content.description`, which is a defined property, but it's `null` → in the next step in `RecordFactory::extractSystemInformation` this will be casted to a blank string.. -
Oliver Hader uploaded patch set 90
V -106/26/24, 10:15 -
core-ci voted on patch set 90 V -1 06/26/24, 10:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60368
-
Benni Mack commented on patch set 90 06/26/24, 10:39
TcaSchemaInterface.php:47Replyyes. I can remove that nowTcaSchemaInterface.php:48ReplyOnly there to make phpstan happy -
Benni Mack uploaded patch set 91
V -106/26/24, 12:45 -
core-ci voted on patch set 91 V -1 06/26/24, 12:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60386
-
Christian Kuhn commented on patch set 90 06/26/24, 12:59
Bootstrap.php:155this is here to register the singleton?ActiveRelation.php:25i'd tend to essentially make *all* new classes final.ActiveRelation.php:28Replyunsure. if, then for *all* classes. problem: there are quite a few getters that access sub properties. *maybe* we should wait for property-hooks from php 8.4 and have getters until then?FieldTypeInterface.php:40i'd tend to not add __set_state() to the interface since this is an internal cache related implementation detail that may change.SchemaInterface.php:28i'd tend to not add __set_state() to the interface since this in an internal cache related thing that may change.FlexSheet.php:39can't we may *all* properties readonly?TcaSchemaFactory.php:56let's not add new usages of SingletonInterface. this service should be shared:true (default), and that's it?!TcaSchemaFactory.php:79i would tend to make $tca not nullable and force consumers accessing $GLOBALS instead. this will free the factory from accessing globals instead.TcaSchemaFactory.php:87let's make $tca non optional and force consumers handing over TCA (from globals), to free this class from GLOBALS access. is it possible to split the method into two? load() and loadUncached() maybe? -
Benni Mack uploaded patch set 92
V -106/26/24, 14:52 -
Benni Mack uploaded patch set 93 06/26/24, 14:53
-
Benni Mack commented on patch set 93 06/26/24, 14:56
Bootstrap.php:155Replythis is now here to populate the Schema from $GLOBALS[TCA]ActiveRelation.php:28Replywon't do this here. As long as we don't use the Relation part yet, I would keep it for now. Making the other properties public isn't working (in the fields).FieldTypeInterface.php:40Replyas far as I understood bnf correctly: If we don't add this to the interface, the system will be broken due to the caching part. I tend to leave it in there for the time being: Rather remove sth in an interface later than to add sth later to an interface. In addition: I did perf tests and did not find a huge difference between unserialize and var_export with objects, except that unserialize() has roughly 66% of the cached file size.SchemaInterface.php:28Replysee aboveFlexSheet.php:39ReplydoneTcaSchemaFactory.php:56ReplyDoneTcaSchemaFactory.php:79ReplyDoneTcaSchemaFactory.php:87ReplyI made the tca non-optional, the method should also not be used outside anymore, bur rather happen in the container, once TCA is/was populated. -
Benni Mack commented on patch set 93 06/26/24, 14:57
Reply
DoneTcaSchemaInterface.php:47ReplyDoneTcaSchemaInterface.php:48ReplyDoneFeature-104002-SchemaAPI.rst:69ReplyDoneFeature-104002-SchemaAPI.rst:93ReplyDone -
core-ci voted on patch set 92 V -1 06/26/24, 14:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60394
-
core-ci voted on patch set 93 V -1 06/26/24, 14:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60395
-
Benni Mack uploaded patch set 94
V -106/26/24, 21:19 -
core-ci voted on patch set 94 V -1 06/26/24, 21:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60416
-
Benni Mack uploaded patch set 95
V -106/26/24, 21:40 -
core-ci voted on patch set 95 V -1 06/26/24, 21:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60417
-
Benni Mack uploaded patch set 96
V -106/26/24, 21:48 -
core-ci voted on patch set 96 V +1 06/26/24, 21:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60418
-
Benni Mack commented on patch set 96 06/26/24, 21:56
ActiveRelation.php:25ReplyI disagree with "_all_", while I made a lot of classes now final and readonly (FieldTypes etc), some essentials where we also use DI are kept as is IMHO. -
Christian Kuhn commented on patch set 96 06/27/24, 13:16
TcaSchemaFactory.php:87ReplyDone -
Benni Mack uploaded patch set 97
V +106/27/24, 13:32 -
core-ci voted on patch set 97 V +1 06/27/24, 13:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60464
-
Christian Kuhn commented on patch set 97 CR +1 V +1 06/27/24, 15:09
Ok. This is a central patch with huge overall impact, at least mid-term. The basic class structure looks good to me - which is the most important thing. I think we'll see if this really works out when we further implement usages within the core. The patch has some rough edges, and I think we'll fine tune the one or the other detail when we start making heavy use of it. I couldn't find anything that *really hurts* at the moment, and I think we have a strong consensus we need such a structure anyway. According to the fact that the entire thing is @internal as well currently, I really think we should go ahead and bring it in, if nobody else raises *significant* concerns. Note the test coverage looks somehow a bit short, overall: Many type's are rather 'dumb', though, so coverage wouldn't add much value. The more central factories and buliders do have basic coverage, though. I think we'll continue to add more when single questions are raised on the structure.RelationMapBuilder.php:65this should be DI, FFT is stateless meanwhile and can be shared. -
Oliver Hader voted on patch set 97 CR +1 06/27/24, 17:53
-
Oli Bartsch voted on patch set 97 CR +1 V +1 06/27/24, 18:45
-
Benni Mack commented on patch set 97 CR +2 V +2 06/27/24, 18:47
RelationMapBuilder.php:65Replywill be handled separately -
Benni Mack merged patch set 98 06/27/24, 18:47