Review main Merged

75486[FEATURE] Introduce Schema API for TCA

Benni Mack CR +2 V +2 Nightmare +5128 −873 updated 06/27/24, 18:47

Commit message

This feature introduces a schema for *reading*
information out of TCA, especially when working
with data from the database that is TYPO3-specific
only to be based on "types" (e.g. tt_content) or
a specific "subtype" (e.g. the value from tt_content.CType,
such as "tt_content.textmedia"), or detecting
information from the global TCA definition.

The basic structure works as follows:

TcaSchemaFactory serves as the basic entry point
for fetching the schema for e.g. tt_content.textmedia
which then resolves all information from TCA
based on the "tca" schema.

A Schema can be the main TCA table information
(with everything) or the "subSchema".

A Schema contains a list of "Capabilities"
(typically within "ctrl" section), possible
sub schemata, and all fields registered in "showitem"
(for a subtype).

The Fields are divided by the "type=..." information
in TCA. Non-recognized type fields are skipped for the
time being.

Only TcaSchemaFactory knows about the actual full
TCA information and builds objects out of it.

Schemas and Fields are put in collections so they
can never be modified after the Boostrap process is
completed.

Before the schema objects are built, the RelationMap
is built, which contains information which fields
contain information that records "might" have a connection
to another database field or table. These are then
attached to the Schema and Field objects as
Active and Passive Relations.

Building the Schema API as graph thus in turn needs
to run two times over all TCA information and all
registered FlexForm data structure definitions
(as flexforms might also contain relations to tables).

Relations are built as loose DTO relation informations
and not as pointers to Schema objects.

Missing parts to be evaluated later-on:
- Can this be used for Site Configuration definitions
  as well?
- "Subsubtype" resolving (tt_content.list and list_type)
- childTca resolving (if this is possible)
- having a colon ":" in type field (maybe related to childTca)
- Add tests for Flex once it is clear how it is needed in DataHandler

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Christian Kuhn +1
    • Oliver Hader +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 93

Show 73 more files

Review log 133229

Show 115204 earlier messages
  1. Benni Mack uploaded patch set 1 08/17/22, 21:05

  2. core-ci voted on patch set 1 V -1 08/17/22, 21:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30252

  3. Benni Mack uploaded patch set 2 08/18/22, 12:05

  4. core-ci voted on patch set 2 V -1 08/18/22, 12:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30268

  5. Nikita Hovratov commented on patch set 2 08/18/22, 12:15

    We could further objectify the configuration part like I did here: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74264
  6. Benni Mack commented on patch set 2 08/18/22, 12:18

    Reply

    Yes. Thought about that. However, I think we should first nail the Schema (that is: let's identify the important points for a field) and then build composition objects for the configuration for e.g. FormEngine, where we need exactly this information. The puzzle is almost complete now: * RelationalFields (select, group, irre, category) are missing * ColumnsOverrides is missing Once I have solved this, I would like to apply this to Page Module Content Element Preview rendering, and see how this works out, before we dive into FormEngine, I'd say.
  7. Benni Mack uploaded patch set 3 08/18/22, 13:16

  8. core-ci voted on patch set 3 V -1 08/18/22, 13:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30271

  9. Benni Mack uploaded patch set 4 08/18/22, 13:26

  10. core-ci voted on patch set 4 V -1 08/18/22, 13:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30272

  11. Nikita Hovratov uploaded patch set 5 08/26/22, 18:23

  12. core-ci voted on patch set 5 V -1 08/26/22, 18:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30473

  13. Nikita Hovratov uploaded patch set 6 08/26/22, 19:22

  14. core-ci voted on patch set 6 V -1 08/26/22, 19:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30474

  15. Nikita Hovratov uploaded patch set 7 08/26/22, 20:34

  16. core-ci voted on patch set 7 V -1 08/26/22, 20:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30475

  17. Nikita Hovratov uploaded patch set 8 08/26/22, 22:02

  18. core-ci voted on patch set 8 V -1 08/26/22, 22:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30476

  19. Nikita Hovratov commented on patch set 8 08/26/22, 22:30

    We now need to rethink all functional tests, which modify TCA on the fly. This isn't possible anymore, as TCA is locked after the initial compilation.
  20. Nikita Hovratov uploaded patch set 9 08/27/22, 00:54

  21. core-ci voted on patch set 9 V +1 08/27/22, 01:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30477

  22. Nikita Hovratov uploaded patch set 10 08/27/22, 08:45

  23. core-ci voted on patch set 10 V +1 08/27/22, 08:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30481

  24. Nikita Hovratov uploaded patch set 11 08/27/22, 11:22

  25. core-ci voted on patch set 11 V -1 08/27/22, 11:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30482

  26. Nikita Hovratov uploaded patch set 12 08/27/22, 11:43

  27. core-ci voted on patch set 12 V -1 08/27/22, 11:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30483

  28. Nikita Hovratov uploaded patch set 13 08/27/22, 11:52

  29. core-ci voted on patch set 13 V -1 08/27/22, 12:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30484

  30. Oliver Klee commented on patch set 13 08/27/22, 12:03

    TcaSchemaInterface.php:31

    This change doesn't look right to me. Should that possibly be SchemaCollection<TcaSchema>, or am I missing something here?
  31. Nikita Hovratov uploaded patch set 14 08/27/22, 12:10

  32. core-ci voted on patch set 14 V +1 08/27/22, 12:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30485

  33. Nikita Hovratov commented on patch set 14 08/27/22, 12:21

    TcaSchemaInterface.php:31 Reply

    Hey Oliver, this patch is still wip. I added it, so phpstorm can autocomplete methods for me. SchemaCollection<TcaSchema> will not work sadly. This will probably be removed / improved afterwards.
  34. Nikita Hovratov commented on patch set 14 08/27/22, 12:21

    TcaSchemaInterface.php:31 Reply

    Done
  35. Nikita Hovratov uploaded patch set 15 08/27/22, 12:37

  36. Oliver Klee commented on patch set 14 08/27/22, 12:38

    TcaSchemaInterface.php:31 Reply

    Maybe we can use Generics for SchemaCollection for this. I you would like to have help with this, please let me know.
  37. core-ci voted on patch set 15 V -1 08/27/22, 12:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30487

  38. Nikita Hovratov uploaded patch set 16 08/27/22, 14:52

  39. core-ci voted on patch set 16 V -1 08/27/22, 14:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30491

  40. Nikita Hovratov uploaded patch set 17 08/27/22, 15:09

  41. core-ci voted on patch set 17 V -1 08/27/22, 15:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30492

  42. Nikita Hovratov uploaded patch set 18 08/27/22, 15:24

  43. core-ci voted on patch set 18 V -1 08/27/22, 15:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30493

  44. Nikita Hovratov uploaded patch set 19 08/27/22, 15:55

  45. Nikita Hovratov commented on patch set 19 08/27/22, 15:58

    TcaSchemaInterface.php:31 Reply

    Thanks, maybe at a later stage? Don't want to burden you with work, if this gets discarded anyway. As of now, there is only one Schema. I don't know if Benni planned to add more.
  46. Oliver Klee commented on patch set 19 08/27/22, 16:02

    TcaSchemaInterface.php:31 Reply

    Just let me know when I should have a look. (In the current state, the annotation is not correct, so I would prefer this change to not get merged with the current annotation.)
  47. core-ci voted on patch set 19 V -1 08/27/22, 16:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30494

  48. Nikita Hovratov uploaded patch set 20 08/27/22, 16:25

  49. core-ci voted on patch set 20 V +1 08/27/22, 16:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30495

  50. Nikita Hovratov uploaded patch set 21 08/28/22, 18:00

  51. core-ci voted on patch set 21 V +1 08/28/22, 18:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30505

  52. Nikita Hovratov uploaded patch set 22 08/28/22, 18:20

  53. core-ci voted on patch set 22 V +1 08/28/22, 18:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30506

  54. Nikita Hovratov uploaded patch set 23 08/28/22, 18:41

  55. core-ci voted on patch set 23 V -1 08/28/22, 18:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30507

  56. Nikita Hovratov uploaded patch set 24 08/28/22, 18:55

  57. core-ci voted on patch set 24 V +1 08/28/22, 19:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30508

  58. Nikita Hovratov uploaded patch set 25 08/28/22, 19:10

  59. core-ci voted on patch set 25 V +1 08/28/22, 19:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30509

  60. Nikita Hovratov uploaded patch set 26 08/28/22, 19:24

  61. core-ci voted on patch set 26 V +1 08/28/22, 19:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30510

  62. Nikita Hovratov uploaded patch set 27 08/29/22, 08:37

  63. core-ci voted on patch set 27 V +1 08/29/22, 08:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30518

  64. Nikita Hovratov uploaded patch set 28 08/29/22, 15:14

  65. core-ci voted on patch set 28 V +1 08/29/22, 15:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30521

  66. Nikita Hovratov uploaded patch set 29 08/29/22, 16:15

  67. core-ci voted on patch set 29 V -1 08/29/22, 16:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30523

  68. Nikita Hovratov uploaded patch set 30 08/29/22, 16:53

  69. core-ci voted on patch set 30 V +1 08/29/22, 17:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30526

  70. Nikita Hovratov uploaded patch set 31 08/30/22, 07:56

  71. Nikita Hovratov uploaded patch set 32 08/30/22, 08:00

  72. core-ci voted on patch set 31 V +1 08/30/22, 08:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30530

  73. core-ci voted on patch set 32 V +1 08/30/22, 08:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30531

  74. Nikita Hovratov uploaded patch set 33 08/30/22, 16:32

  75. core-ci voted on patch set 33 V +1 08/30/22, 16:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30547

  76. Nikita Hovratov uploaded patch set 34 08/30/22, 16:43

  77. core-ci voted on patch set 34 V +1 08/30/22, 16:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30548

  78. Nikita Hovratov uploaded patch set 35 08/30/22, 16:58

  79. core-ci voted on patch set 35 V +1 08/30/22, 17:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30549

  80. Nikita Hovratov uploaded patch set 36 08/30/22, 17:55

  81. core-ci voted on patch set 36 V -1 08/30/22, 18:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30550

  82. Nikita Hovratov uploaded patch set 37 08/30/22, 18:17

  83. core-ci voted on patch set 37 V +1 08/30/22, 18:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30551

  84. Nikita Hovratov uploaded patch set 38 08/30/22, 18:39

  85. core-ci voted on patch set 38 V +1 08/30/22, 18:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30552

  86. Nikita Hovratov uploaded patch set 39 08/31/22, 10:33

  87. core-ci voted on patch set 39 V +1 08/31/22, 10:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30556

  88. Nikita Hovratov uploaded patch set 40 08/31/22, 10:57

  89. core-ci voted on patch set 40 V -1 08/31/22, 11:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30557

  90. Nikita Hovratov uploaded patch set 41 08/31/22, 12:05

  91. core-ci voted on patch set 41 V +1 08/31/22, 12:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30560

  92. Nikita Hovratov uploaded patch set 42 08/31/22, 12:29

  93. core-ci voted on patch set 42 V +1 08/31/22, 12:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30561

  94. Nikita Hovratov uploaded patch set 43 09/01/22, 09:32

  95. core-ci voted on patch set 43 V -1 09/01/22, 09:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30575

  96. Nikita Hovratov uploaded patch set 44 09/01/22, 09:47

  97. core-ci voted on patch set 44 V +1 09/01/22, 09:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30576

  98. Nikita Hovratov uploaded patch set 45 09/01/22, 10:06

  99. core-ci voted on patch set 45 V +1 09/01/22, 10:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30577

  100. Nikita Hovratov uploaded patch set 46 09/01/22, 10:17

  101. core-ci voted on patch set 46 V -1 09/01/22, 10:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30578

  102. Nikita Hovratov uploaded patch set 47 09/01/22, 10:32

  103. core-ci voted on patch set 47 V +1 09/01/22, 10:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30579

  104. Benni Mack commented on patch set 47 09/05/22, 14:41

    AbstractFieldType.php:116

    we should use getTranslationBehaviour instead.
  105. Nikita Hovratov commented on patch set 47 09/05/22, 15:29

    AbstractFieldType.php:116 Reply

    The problem is, that it's possible to mix "allowLanguageSynchronisation" and "l10n_mode", so we can't return only translationBehaviour, can we?
  106. Benni Mack uploaded patch set 48 09/06/22, 17:02

  107. core-ci voted on patch set 48 V -1 09/06/22, 17:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30657

  108. Benni Mack uploaded patch set 49 09/07/22, 10:40

  109. core-ci voted on patch set 49 V -1 09/07/22, 10:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30731

  110. Benni Mack uploaded patch set 50 09/07/22, 12:32

  111. core-ci voted on patch set 50 V -1 09/07/22, 12:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30750

  112. Benni Mack uploaded patch set 51 09/07/22, 13:13

  113. core-ci voted on patch set 51 V -1 09/07/22, 13:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30751

  114. Benni Mack uploaded patch set 52 09/07/22, 14:32

  115. core-ci voted on patch set 52 V -1 09/07/22, 14:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30757

  116. Benni Mack uploaded patch set 53 09/07/22, 15:00

  117. Benni Mack uploaded patch set 54 09/07/22, 15:08

  118. core-ci voted on patch set 53 V -1 09/07/22, 15:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30760

  119. core-ci voted on patch set 54 V -1 09/07/22, 15:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30762

  120. Benni Mack uploaded patch set 55 09/07/22, 17:44

  121. core-ci voted on patch set 55 V -1 09/07/22, 17:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30775

  122. Benni Mack uploaded patch set 56 09/07/22, 19:17

  123. core-ci voted on patch set 56 V -1 09/07/22, 19:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30779

  124. Benni Mack uploaded patch set 57 09/07/22, 19:40

  125. core-ci voted on patch set 57 V -1 09/07/22, 19:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30781

  126. Benni Mack uploaded patch set 58 09/07/22, 20:04

  127. Benni Mack uploaded patch set 59 09/07/22, 20:53

  128. core-ci voted on patch set 59 V -1 09/07/22, 21:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30784

  129. Benni Mack uploaded patch set 60 09/08/22, 09:20

  130. core-ci voted on patch set 60 V -1 09/08/22, 09:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30798

  131. Benni Mack uploaded patch set 61 09/08/22, 10:40

  132. core-ci voted on patch set 61 V -1 09/08/22, 10:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30803

  133. Benni Mack uploaded patch set 62 09/08/22, 11:49

  134. core-ci voted on patch set 62 V -1 09/08/22, 12:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30811

  135. Benni Mack uploaded patch set 63 09/08/22, 12:17

  136. core-ci voted on patch set 63 V +1 09/08/22, 12:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30813

  137. Benni Mack uploaded patch set 64 09/08/22, 12:59

  138. core-ci voted on patch set 64 V -1 09/08/22, 13:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30817

  139. Benni Mack uploaded patch set 65 09/08/22, 13:52

  140. core-ci voted on patch set 65 V -1 09/08/22, 14:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30821

  141. Benni Mack rebased onto patch set 66 09/08/22, 17:14

  142. core-ci voted on patch set 66 V -1 09/08/22, 17:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30852

  143. Benni Mack commented on patch set 66 09/09/22, 10:12

    Feedback from Susi: - Use Constants / Enum for built-in Capabilities - Use getcapability() with nullable to make usages easier to understand in favor of "isLanguageAware" and "isWorkspaceAware" to be fully consistent
  144. Benni Mack uploaded patch set 67 10/17/22, 10:48

  145. core-ci voted on patch set 67 V -1 10/17/22, 11:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32385

  146. Benni Mack uploaded patch set 68 10/20/22, 19:13

  147. core-ci voted on patch set 68 V -1 10/20/22, 19:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32530

  148. Nikita Hovratov commented on patch set 68 10/21/22, 13:07

    @benni Did you delete SchemaCapability.php by mistake in the last patchset? Looked to me like a rebase only.
  149. Benni Mack commented on patch set 68 10/21/22, 14:18

    Reply

    yes, I think it's not suitable for the API right now. Will stick to the approach right now, and "just" add the relational part to it.
  150. Benni Mack uploaded patch set 69 V -1 12/06/22, 15:40

  151. core-ci voted on patch set 69 V -1 12/06/22, 15:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34725

  152. Benni Mack uploaded patch set 70 V -1 01/10/23, 09:52

  153. core-ci voted on patch set 70 V -1 01/10/23, 09:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35638

  154. Benni Mack uploaded patch set 71 V -1 01/10/23, 10:29

  155. core-ci voted on patch set 71 V +1 01/10/23, 10:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35640

  156. Benni Mack rebased onto patch set 72 V +1 01/18/23, 21:35

  157. core-ci voted on patch set 72 V +1 01/18/23, 21:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36155

  158. Benni Mack marked it work in progress 03/24/23, 11:45

  159. Andreas Kienast commented on patch set 72 06/10/24, 08:51

    TcaSchema.php:114

    The lists of capabilities here and in `getCapability()` look huge. Perhaps we can have some kind of an capability map that is filled. Also, the capability identifiers could be actual enums.
  160. Benni Mack uploaded patch set 73 V +1 06/10/24, 21:02

  161. core-ci voted on patch set 73 V -1 06/10/24, 21:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59078

  162. Benni Mack uploaded patch set 74 V -1 06/11/24, 14:23

  163. core-ci voted on patch set 74 V -1 06/11/24, 14:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59200

  164. Benni Mack uploaded patch set 75 V -1 06/11/24, 15:06

  165. core-ci voted on patch set 75 V -1 06/11/24, 15:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59205

  166. Benni Mack uploaded patch set 76 V -1 06/11/24, 19:27

  167. core-ci voted on patch set 76 V -1 06/11/24, 19:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59243

  168. Benni Mack uploaded patch set 77 V -1 06/12/24, 09:34

  169. core-ci voted on patch set 77 V -1 06/12/24, 10:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59299

  170. Benni Mack uploaded patch set 78 V -1 06/12/24, 13:23

  171. core-ci voted on patch set 78 V -1 06/12/24, 13:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59327

  172. Benni Mack uploaded patch set 79 V -1 06/12/24, 19:20

  173. Benni Mack marked it ready for review 06/12/24, 19:21

  174. Benni Mack commented on patch set 79 06/12/24, 19:21

    TcaSchema.php:114 Reply

    Done
  175. core-ci voted on patch set 79 V -1 06/12/24, 19:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59363

  176. Benni Mack uploaded patch set 80 V -1 06/12/24, 19:45

  177. core-ci voted on patch set 80 V -1 06/12/24, 19:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59367

  178. Nikita Hovratov commented on patch set 80 06/12/24, 20:10

    RelationshipType.php:49

    or "allowed" for type group.
  179. Benni Mack uploaded patch set 81 V -1 06/13/24, 06:40

  180. core-ci voted on patch set 81 V -1 06/13/24, 06:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59402

  181. Benni Mack uploaded patch set 82 V -1 06/13/24, 07:29

  182. core-ci voted on patch set 82 V +1 06/13/24, 07:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59413

  183. Benni Mack uploaded patch set 83 V +1 06/13/24, 09:09

  184. core-ci voted on patch set 83 V -1 06/13/24, 09:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59437

  185. Nikita Hovratov commented on patch set 83 06/13/24, 09:38

    TcaSchemaFactory.php:296

    parenthesis missing around the second part.
  186. Benni Mack uploaded patch set 84 V -1 06/13/24, 10:46

  187. Oliver Klee wrote 06/13/24, 10:46

    Removed cc Oliver Klee.
  188. core-ci voted on patch set 84 V -1 06/13/24, 10:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59463

  189. Benni Mack uploaded patch set 85 V -1 06/13/24, 12:54

  190. Benni Mack commented on patch set 85 06/13/24, 12:56

    AbstractFieldType.php:116 Reply

    currently, Schema API does not handle allowLanguageSynchronization. I left it out for the time being, as this option is only evaluated in 2 places in TYPO3 Core.

    RelationshipType.php:49 Reply

    Done

    TcaSchemaFactory.php:296 Reply

    Done
  191. core-ci voted on patch set 85 V -1 06/13/24, 13:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59486

  192. Christian Kuhn commented on patch set 84 06/13/24, 13:48

    Feature-104002-SchemaAPI.rst:69

    i still don't really understand the difference ... need to think about and let it sink in ...

    Feature-104002-SchemaAPI.rst:93

    skip. heavily internal. ext authors must never do this and core should get rid of it.
  193. Benni Mack uploaded patch set 86 V -1 06/13/24, 15:08

  194. core-ci voted on patch set 86 V +1 06/13/24, 15:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59505

  195. Benjamin Franzke uploaded patch set 87 V +1 06/13/24, 19:00

  196. core-ci voted on patch set 87 V -1 06/13/24, 19:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59535

  197. Benni Mack uploaded patch set 88 V -1 06/14/24, 07:14

  198. core-ci voted on patch set 88 V +1 06/14/24, 07:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59573

  199. Oliver Hader commented on patch set 88 06/26/24, 08:14

    ActiveRelation.php:28

    Shall we use public properties instead and drop the getters?

    TcaSchemaInterface.php:47

    I'm not sure, where `string` should be supported here in the interface...

    TcaSchemaInterface.php:48

    Hm, hm, hm... pretty hard-coded inference list
  200. Oliver Hader uploaded patch set 89 V +1 06/26/24, 08:15

  201. core-ci voted on patch set 89 V -1 06/26/24, 08:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60357

  202. Oliver Hader commented on patch set 89 06/26/24, 09:51

    The (new) failing tests are related to `tt_content.description`, which is a defined property, but it's `null` → in the next step in `RecordFactory::extractSystemInformation` this will be casted to a blank string..
  203. Oliver Hader uploaded patch set 90 V -1 06/26/24, 10:15

  204. core-ci voted on patch set 90 V -1 06/26/24, 10:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60368

  1. Benni Mack commented on patch set 90 06/26/24, 10:39

    TcaSchemaInterface.php:47 Reply

    yes. I can remove that now

    TcaSchemaInterface.php:48 Reply

    Only there to make phpstan happy
  2. Benni Mack uploaded patch set 91 V -1 06/26/24, 12:45

  3. core-ci voted on patch set 91 V -1 06/26/24, 12:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60386

  4. Christian Kuhn commented on patch set 90 06/26/24, 12:59

    Bootstrap.php:155

    this is here to register the singleton?

    ActiveRelation.php:25

    i'd tend to essentially make *all* new classes final.

    ActiveRelation.php:28 Reply

    unsure. if, then for *all* classes. problem: there are quite a few getters that access sub properties. *maybe* we should wait for property-hooks from php 8.4 and have getters until then?

    FieldTypeInterface.php:40

    i'd tend to not add __set_state() to the interface since this is an internal cache related implementation detail that may change.

    SchemaInterface.php:28

    i'd tend to not add __set_state() to the interface since this in an internal cache related thing that may change.

    FlexSheet.php:39

    can't we may *all* properties readonly?

    TcaSchemaFactory.php:56

    let's not add new usages of SingletonInterface. this service should be shared:true (default), and that's it?!

    TcaSchemaFactory.php:79

    i would tend to make $tca not nullable and force consumers accessing $GLOBALS instead. this will free the factory from accessing globals instead.

    TcaSchemaFactory.php:87

    let's make $tca non optional and force consumers handing over TCA (from globals), to free this class from GLOBALS access. is it possible to split the method into two? load() and loadUncached() maybe?
  5. Benni Mack uploaded patch set 92 V -1 06/26/24, 14:52

  6. Benni Mack uploaded patch set 93 06/26/24, 14:53

  7. Benni Mack commented on patch set 93 06/26/24, 14:56

    Bootstrap.php:155 Reply

    this is now here to populate the Schema from $GLOBALS[TCA]

    ActiveRelation.php:28 Reply

    won't do this here. As long as we don't use the Relation part yet, I would keep it for now. Making the other properties public isn't working (in the fields).

    FieldTypeInterface.php:40 Reply

    as far as I understood bnf correctly: If we don't add this to the interface, the system will be broken due to the caching part. I tend to leave it in there for the time being: Rather remove sth in an interface later than to add sth later to an interface. In addition: I did perf tests and did not find a huge difference between unserialize and var_export with objects, except that unserialize() has roughly 66% of the cached file size.

    SchemaInterface.php:28 Reply

    see above

    FlexSheet.php:39 Reply

    done

    TcaSchemaFactory.php:56 Reply

    Done

    TcaSchemaFactory.php:79 Reply

    Done

    TcaSchemaFactory.php:87 Reply

    I made the tca non-optional, the method should also not be used outside anymore, bur rather happen in the container, once TCA is/was populated.
  8. Benni Mack commented on patch set 93 06/26/24, 14:57

    Reply

    Done

    TcaSchemaInterface.php:47 Reply

    Done

    TcaSchemaInterface.php:48 Reply

    Done

    Feature-104002-SchemaAPI.rst:69 Reply

    Done

    Feature-104002-SchemaAPI.rst:93 Reply

    Done
  9. core-ci voted on patch set 92 V -1 06/26/24, 14:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60394

  10. core-ci voted on patch set 93 V -1 06/26/24, 14:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60395

  11. Benni Mack uploaded patch set 94 V -1 06/26/24, 21:19

  12. core-ci voted on patch set 94 V -1 06/26/24, 21:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60416

  13. Benni Mack uploaded patch set 95 V -1 06/26/24, 21:40

  14. core-ci voted on patch set 95 V -1 06/26/24, 21:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60417

  15. Benni Mack uploaded patch set 96 V -1 06/26/24, 21:48

  16. core-ci voted on patch set 96 V +1 06/26/24, 21:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60418

  17. Benni Mack commented on patch set 96 06/26/24, 21:56

    ActiveRelation.php:25 Reply

    I disagree with "_all_", while I made a lot of classes now final and readonly (FieldTypes etc), some essentials where we also use DI are kept as is IMHO.
  18. Christian Kuhn commented on patch set 96 06/27/24, 13:16

    TcaSchemaFactory.php:87 Reply

    Done
  19. Benni Mack uploaded patch set 97 V +1 06/27/24, 13:32

  20. core-ci voted on patch set 97 V +1 06/27/24, 13:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60464

  21. Christian Kuhn commented on patch set 97 CR +1 V +1 06/27/24, 15:09

    Ok. This is a central patch with huge overall impact, at least mid-term. The basic class structure looks good to me - which is the most important thing. I think we'll see if this really works out when we further implement usages within the core. The patch has some rough edges, and I think we'll fine tune the one or the other detail when we start making heavy use of it. I couldn't find anything that *really hurts* at the moment, and I think we have a strong consensus we need such a structure anyway. According to the fact that the entire thing is @internal as well currently, I really think we should go ahead and bring it in, if nobody else raises *significant* concerns. Note the test coverage looks somehow a bit short, overall: Many type's are rather 'dumb', though, so coverage wouldn't add much value. The more central factories and buliders do have basic coverage, though. I think we'll continue to add more when single questions are raised on the structure.

    RelationMapBuilder.php:65

    this should be DI, FFT is stateless meanwhile and can be shared.
  22. Oliver Hader voted on patch set 97 CR +1 06/27/24, 17:53

  23. Oli Bartsch voted on patch set 97 CR +1 V +1 06/27/24, 18:45

  24. Benni Mack commented on patch set 97 CR +2 V +2 06/27/24, 18:47

    RelationMapBuilder.php:65 Reply

    will be handled separately
  25. Benni Mack merged patch set 98 06/27/24, 18:47