75489[TASK] Remove jQuery usages in EXT:dashboard
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Benjamin Franzke +1
- Frank Nägler +1
-
Verified V +2 Done
- Andreas Kienast +2
- Benjamin Franzke +1
- Frank Nägler +1
- core-ci +1 CI
Issues 1
Files 5
- Build/Sources/TypeScript/dashboard/dashboard-modal.ts+1 −2
- Build/Sources/TypeScript/dashboard/widget-selector.ts+1 −2
- typo3/sysext/dashboard/Resources/Private/Templates/Dashboard/Main.html+6 −6
- typo3/sysext/dashboard/Resources/Public/JavaScript/dashboard-modal.js+1 −1
- typo3/sysext/dashboard/Resources/Public/JavaScript/widget-selector.js+1 −1
Review log 1215
-
Andreas Kienast uploaded patch set 1 08/18/22, 08:58
-
Andreas Kienast commented on patch set 1 CR -2 08/18/22, 08:59
Depends on https://review.typo3.org/c/Packages/TYPO3.CMS/+/75488 -
core-ci voted on patch set 1 V +1 08/18/22, 09:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30263
-
Andreas Kienast updated the commit message in patch set 2 08/18/22, 10:46
-
Andreas Kienast voted on patch set 2 CR 0 08/18/22, 10:46
-
core-ci voted on patch set 2 V +1 08/18/22, 10:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30267
-
Frank Nägler voted on patch set 2 V +1 08/18/22, 11:55
-
Frank Nägler voted on patch set 2 CR +1 08/18/22, 11:56
-
Benjamin Franzke commented on patch set 2 V -1 08/18/22, 18:47
The modals work only once, as the elements are moved from the HTML to the modal which is then removed. Therefore the DOM contents are removed. In the second the modals are empty. Either we clone the nodes, or even better use a <template> tag. -
Benjamin Franzke uploaded patch set 3 08/18/22, 19:09
-
core-ci voted on patch set 3 V +1 08/18/22, 19:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30276
-
Frank Nägler voted on patch set 3 CR +1 08/19/22, 06:18
-
Frank Nägler voted on patch set 3 V +1 08/19/22, 06:27
-
Andreas Kienast voted on patch set 3 V +2 CR +2 08/19/22, 06:28
-
Andreas Kienast merged patch set 4 08/19/22, 06:28