75512[FEATURE] Add TypeConverter for enums
Commit message
Review
-
Code review CR +2 Done
- Anja Leichsenring +2
- Georg Ringer +1
- Benni Mack +1
-
Verified V +2 Done
- Anja Leichsenring +2
- Georg Ringer +1
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 8
- typo3/sysext/core/Documentation/Changelog/12.0/Feature-98171-AddExtbaseTypeConverterForEnums.rstnew+51 −0
- typo3/sysext/extbase/Classes/Property/TypeConverter/EnumConverter.php6new+85 −0
- typo3/sysext/extbase/Configuration/Services.yaml+7 −0
- typo3/sysext/extbase/Tests/Fixture/IntegerBackedEnum.phpnew+25 −0
- typo3/sysext/extbase/Tests/Fixture/StringBackedEnum.phpnew+27 −0
- typo3/sysext/extbase/Tests/Fixture/UnbackedEnum.phpnew+25 −0
- typo3/sysext/extbase/Tests/Functional/Property/TypeConverter/EnumConverterTest.phpnew+136 −0
- typo3/sysext/extbase/Tests/Functional/Property/PropertyMapperTest.php+2 −2
Review log 2943
Show 1318 earlier messages
-
Matthias Vogel uploaded patch set 1 08/18/22, 16:11
-
Matthias Vogel updated the commit message in patch set 2 08/18/22, 16:15
-
core-ci voted on patch set 1 V -1 08/18/22, 16:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30273
-
core-ci voted on patch set 2 V -1 08/18/22, 16:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30274
-
Chris Müller commented on patch set 2 CR -1 08/18/22, 17:21
Pplease also provide a feature RST describing the new feature and how it can be used. -
Chris Müller commented on patch set 2 08/18/22, 17:30
EnumConverter.php:30The deprecated properties are not necessary for a new converter in v12. See: https://docs.typo3.org/c/typo3/cms-core/main/en-us/Changelog/12.0/Deprecation-94117-RegisterExtbaseTypeConvertersAsServices.htmlEnumConverter.php:54Can also be removed. -
Matthias Vogel uploaded patch set 3 08/19/22, 06:45
-
Matthias Vogel updated the commit message in patch set 4 08/19/22, 06:45
-
Matthias Vogel commented on patch set 4 08/19/22, 06:46
Reply
AckEnumConverter.php:30ReplyAckEnumConverter.php:54ReplyAck -
Benni Mack commented on patch set 4 08/19/22, 06:51
Awesome feature, thanks Matthias! -
core-ci voted on patch set 3 V +1 08/19/22, 06:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30288
-
core-ci voted on patch set 4 V +1 08/19/22, 06:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30289
-
Oliver Klee commented on patch set 4 08/19/22, 09:41
Awesome work! I've added a comment regarding marking the test code more clear.Enum.php:20Please let's give this enum a name that is more specific (and that also avoids using the reserved word "enum" as a name ;-) ). Maybe "UnbackedEnum? What do you think? -
Chris Müller uploaded patch set 5 08/19/22, 11:59
-
Chris Müller commented on patch set 5 08/19/22, 12:02
Enum.php:22There is a "convention" that enum cases should by UpperCamelCase, like in the PHP docs example: https://www.php.net/manual/en/language.types.enumerations.php Maybe we can adjust it. Although it is not part of the PSR standard yet, as it is too new. -
Chris Müller commented on patch set 5 08/19/22, 12:04
And: I like the feature also :-) Thanks. -
Chris Müller uploaded patch set 6 08/19/22, 12:06
-
core-ci voted on patch set 5 V +1 08/19/22, 12:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30311
-
core-ci voted on patch set 6 V +1 08/19/22, 12:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30312
-
Matthias Vogel uploaded patch set 7 08/19/22, 13:04
-
Matthias Vogel commented on patch set 7 08/19/22, 13:04
Enum.php:20ReplyAck -
Matthias Vogel uploaded patch set 8 08/19/22, 13:07
-
Matthias Vogel commented on patch set 8 08/19/22, 13:07
Enum.php:22ReplyAck -
Matthias Vogel uploaded patch set 9 08/19/22, 13:08
-
core-ci voted on patch set 7 V +1 08/19/22, 13:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30320
-
core-ci voted on patch set 8 V +1 08/19/22, 13:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30322
-
core-ci voted on patch set 9 V +1 08/19/22, 13:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30323
-
Matthias Vogel uploaded patch set 10 08/26/22, 08:18
-
Matthias Vogel uploaded patch set 11 08/26/22, 08:22
-
core-ci voted on patch set 11 V +1 08/26/22, 08:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30455
-
core-ci voted on patch set 10 V +1 08/26/22, 08:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30454
-
Oliver Klee commented on patch set 11 08/26/22, 09:52
EnumConverter.php:38Can we use the mixed native type declaration for $source in this method and the next? -
Benni Mack commented on patch set 12 09/06/22, 12:55
Published edit on patch set 11. -
Benni Mack commented on patch set 13 09/06/22, 12:56
Published edit on patch set 12. -
core-ci voted on patch set 13 V +1 09/06/22, 13:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30647
-
core-ci voted on patch set 12 V +1 09/06/22, 13:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30646
-
Benni Mack commented on patch set 13 09/06/22, 14:42
EnumConverter.php:38ReplyDone -
Benni Mack uploaded patch set 14 09/06/22, 19:50
-
Benni Mack voted on patch set 14 V +1 CR +1 09/06/22, 19:50
-
core-ci voted on patch set 14 V +1 09/06/22, 20:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30678
-
Georg Ringer voted on patch set 14 V +1 CR +1 09/06/22, 20:39
-
Anja Leichsenring voted on patch set 14 V +2 CR +2 09/07/22, 17:17
-
Anja Leichsenring merged patch set 15 09/07/22, 17:17