Review main Merged

75517[BUGFIX] Convert Node to DocumentFragment for modal consumption in EXT:dashboard

Andreas Kienast CR +2 V +2 Easy +12 −4 updated 08/19/22, 09:13

Commit message

The patches #98164 and #98165 conflicted with each other as one made
the modal API stricter while the other populated the modal with a
soon-to-be invalid configuration. This currently breaks all subsequent
builds.

The modals received objects of type `Node` which are not consumable by
jQuery's `append()` method. To solve this issue, `Node` is now converted
to a `DocumentFragment`, which can be consumed by all involved parties.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 3

Files 4