Review main Merged

75526[BUGFIX] Allow EmailFinisher recipients override with TypoScript again

Gerrit Mohrmann CR +2 V +2 Easy +12 −0 updated 07/08/23, 11:24

Commit message

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • Johannes Seipelt +1
  • Verified V +2 Done
    • Benni Mack +2
    • Johannes Seipelt +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 2126

Show 1 earlier messages
  1. Gerrit Mohrmann uploaded patch set 1 08/19/22, 19:24

  1. core-ci voted on patch set 1 V +1 08/19/22, 19:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30328

  2. Gerrit Mohrmann commented on patch set 1 V +1 CR +1 10/22/22, 09:42

    What is the next step to get attention on this?
  3. Oliver Klee commented on patch set 1 10/22/22, 09:44

    Hi Gerrit, > What is the next step to get attention on this? you can post a link to the change in the core channel on Slack. (I’ve just done that for you.) Also, please do not vote on your own changes in Gerrit (that’s not allowed, even if Gerrit does not prevent this). Thanks!
  4. Stefan Bürk updated the commit message in patch set 2 10/22/22, 20:07

  5. core-ci voted on patch set 2 V -1 10/22/22, 20:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32621

  6. Stefan Bürk rebased onto patch set 3 10/22/22, 21:27

  7. core-ci voted on patch set 3 V +1 10/22/22, 21:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32622

  8. Johannes Seipelt commented on patch set 3 01/06/23, 22:02

    stumbled upon this issue - setting the name with typoscript is a nice to have, but not needed for the bugfix itself, maybe just reverting to https://github.com/TYPO3/typo3/blob/10.4/typo3/sysext/form/Classes/Domain/Finishers/EmailFinisher.php#L367 would be better?
  9. Johannes Seipelt voted on patch set 3 CR +1 01/06/23, 22:29

  10. Gerrit Mohrmann commented on patch set 3 01/08/23, 13:55

    Reply

    Yes, will fix it too, but why better? My opinion is what leads to a faster merge should be done. Already too much time has passed for a simple regression fix. But, it doesn't seem to be stopping many from updating to v11. Feature doesn't seem to be used much. Who decides that?
  11. Johannes Seipelt commented on patch set 3 01/08/23, 17:23

    Reply

    we need a core developer with merge power, already posted it again in the core dev slack channel and commented in forge. There is only so much you can do to get attention to the issue, without annoying people. In the meantime patch the core yourself, that's what I am doing (https://github.com/cweagans/composer-patches recommended).
  12. Gerrit Mohrmann commented on patch set 3 04/06/23, 11:20

    ping?

    Reply

    Done
  13. Benni Mack updated the commit message in patch set 4 CR +1 V +1 05/03/23, 09:43

  14. Johannes Seipelt voted on patch set 4 CR +1 05/03/23, 13:01

  15. Gerrit Mohrmann commented on patch set 4 05/05/23, 12:24

    The possibility was dropped with v11, should I add 11.5 again to the Releases line?
  16. Benni Mack rebased onto patch set 5 CR +1 07/04/23, 09:51

  17. core-ci voted on patch set 5 V +1 07/04/23, 10:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43356

  18. Benni Mack updated the commit message in patch set 6 V +1 07/06/23, 19:13

  19. Benni Mack commented on patch set 6 07/06/23, 19:13

    Reply

    Done
  20. core-ci voted on patch set 6 V +1 07/06/23, 19:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43811

  21. Benni Mack voted on patch set 6 CR +1 07/07/23, 14:26

  22. Johannes Seipelt voted on patch set 6 V +1 CR +1 07/07/23, 21:30

  23. Oliver Klee voted on patch set 6 CR +1 07/08/23, 07:29

  24. Benni Mack voted on patch set 6 V +2 CR +2 07/08/23, 11:24

  25. Benni Mack merged patch set 7 07/08/23, 11:24