Review main Merged

75533[BUGFIX] Show workspace toolbar if at least one workspace is available

Georg Ringer CR +2 V +2 Easy +1 −1 updated 03/23/25, 19:02

Commit message

The toolbar must be shown if at least one workspace is available. Not
only can the workspace title help the editor but more important the
toolbar is highlighted as very important visual information.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Christian Kuhn +1
    • Benni Mack +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Christian Kuhn +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 2935

Show 810 earlier messages
  1. Georg Ringer uploaded patch set 1 08/22/22, 20:30

  2. Georg Ringer commented on patch set 1 08/22/22, 20:30

    This change is ready for review.
  3. core-ci voted on patch set 1 V +1 08/22/22, 20:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30362

  4. Stefan Froemken commented on patch set 1 V +1 CR +1 08/23/22, 09:22

    Works, but you have to set users/groups as owners in workspace record. Else, the problem is still the same.
  5. Benni Mack commented on patch set 1 09/05/22, 11:34

    Reply

    We could do a "|| isAdmin()" check? I think it's OK to have the dropdown available for admins at any time. WDYT?
  6. Anja Leichsenring commented on patch set 1 V +1 CR +1 09/06/22, 05:38

    Reply

    as an admin who constantly switches instances, I would be grateful to see whether I am in a workspace enabled instance right now. So for me, this is fine.
  7. Benni Mack commented on patch set 2 09/06/22, 18:53

    Published edit on patch set 1.
  8. Benni Mack commented on patch set 2 09/06/22, 18:54

    Reply

    Done
  9. core-ci voted on patch set 2 V +1 09/06/22, 19:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30671

  10. Georg Ringer voted on patch set 2 V +1 CR +1 09/06/22, 20:40

  1. Stefan Froemken commented on patch set 2 09/07/22, 08:26

    Reply

    Hi Benni. Seems to be a miss-understanding. If no Editor or Group was added to the workspace-record and the editor logs in, then just the toolbar was visible (everything else is white) and the user can't switch from LIVE to his workspace. IMO a check is needed, if BE user has a workspace assigned. If yes, switch to his workspace automatically or show the switch dropdown.
  2. Benni Mack updated the commit message in patch set 3 CR +1 V +1 05/03/23, 09:23

  3. core-ci voted on patch set 3 V -1 05/03/23, 10:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41405

  4. Philipp Kitzberger commented on patch set 3 10/04/23, 16:04

    Just stumped upon this here too. For me this is the correct solution: ``` return count($this->availableWorkspaces) > 1 || !isset($this->availableWorkspaces[0]); ``` A user that has more than one workspaces should obviously see the WS button. A user that has only one workspaces should only then see the WS button IFF it isn't the Live-WS.
  5. Anja Leichsenring wrote 07/31/24, 18:15

    Removed reviewer Anja Leichsenring.
  6. Georg Ringer uploaded patch set 4 V -1 08/06/24, 18:25

  7. core-ci voted on patch set 4 V +1 08/06/24, 18:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62967

  8. Benni Mack commented on patch set 4 CR +1 V +1 08/09/24, 16:12

    Reply

    Thanks for the clarification!
  9. Benni Mack commented on patch set 4 08/09/24, 16:12

    Reply

    Hey Stefan, can you confirm the solution is OK now?
  10. Stefan Froemken commented on patch set 4 08/09/24, 20:41

    Hi Benni. I can't reproduce the original problem anymore, I don't understand my own writing (workspace without assigned owner/editor) ha ha. And the patch does not solve anything. A user without LIVE Workspace is redirected into its one and only workspace automatically on current GIT. So, from my point of view this patch can and should be abadoned.
  11. Benni Mack updated the commit message in patch set 5 CR +1 V +1 10/18/24, 13:42

  12. Georg Ringer commented on patch set 5 02/03/25, 20:02

    still reproducable. it is just about showing the workspace toolbaritem even if the editor got only access to 1 WS (no live). IMHO it is helpful!
  13. Benni Mack rebased onto patch set 6 02/03/25, 20:02

  14. core-ci voted on patch set 6 V +1 02/03/25, 20:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73444

  15. Benni Mack commented on patch set 6 CR +1 V +1 02/10/25, 22:18

    Reply

    Done
  16. Andreas Kienast commented on patch set 6 02/11/25, 12:18

    This is not true anymore since v13
  17. Andreas Kienast commented on patch set 6 CR -1 02/11/25, 12:21

    WorkspaceSelectorToolbarItem.php:56

    I think for readability it would be better to check `$this->getBackendUser()->workspace > 0`
  18. Georg Ringer commented on patch set 6 02/11/25, 19:24

    WorkspaceSelectorToolbarItem.php:56 Reply

    but the toolbar should also be rendered if the user is NOT in a workspace? maybe we could just return true? if EXT:workspace is installed, just show the toolbar - what you think?
  19. Andreas Kienast commented on patch set 6 CR 0 02/11/25, 20:11

    WorkspaceSelectorToolbarItem.php:56 Reply

    Alright, I misunderstood this. I need to check this to have a proper opinion. I will lift my -1 for now.
  20. Benni Mack updated the commit message in patch set 7 CR +1 V +1 03/21/25, 20:20

  21. Benni Mack commented on patch set 7 CR +1 V +1 03/21/25, 20:20

    Reply

    Done
  22. core-ci voted on patch set 7 V +1 03/21/25, 20:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75984

  23. Christian Kuhn voted on patch set 7 CR +1 V +1 03/22/25, 07:43

  24. Georg Ringer voted on patch set 7 CR +2 V +2 03/23/25, 19:02

  25. Georg Ringer merged patch set 8 03/23/25, 19:02