Review main Merged Breaking

75538[!!!][TASK] Remove TODAYS_SPECIAL error constant

Torben Hansen CR +2 V +2 Easy +37 −8 updated 08/24/22, 10:53

Commit message

The constant `TODAYS_SPECIAL` has never been used in TYPO3
core and also 3rd party extensions in TER do not make
use of it. The constant can therefore be removed safely
from the class.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 810

  1. Torben Hansen uploaded patch set 1 08/23/22, 17:09

  2. core-ci voted on patch set 1 V +1 08/23/22, 17:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30382

  3. Georg Ringer voted on patch set 1 V +1 CR +1 08/23/22, 18:24

  4. Stefan Bürk commented on patch set 1 CR -1 08/23/22, 18:50

    Breaking-98195-RemoveTODAYS_SPECIALErrorConstant.rst:14

    Can we use the :php: label here ... and also we have the convention to add classes with FQDN and leading \ ``` :php:`\TYPO3\CMS\Core\SysLog\Error` ``` Same for the TODAYS_SPECIAL as these are "php code constants" - but here not sure about documentation rules.
  5. Torben Hansen uploaded patch set 2 08/24/22, 06:25

  6. Torben Hansen commented on patch set 2 08/24/22, 06:28

    Breaking-98195-RemoveTODAYS_SPECIALErrorConstant.rst:14 Reply

    Done for both the classname and the constant. I checked previous rst files and we used `:php:` the the `TYPO3_MODE` constant deprecation.
  7. core-ci voted on patch set 2 V +1 08/24/22, 06:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30401

  8. Andreas Kienast voted on patch set 2 V +1 CR +1 08/24/22, 06:55

  9. Christian Kuhn voted on patch set 2 V +2 CR +2 08/24/22, 10:53

  10. Christian Kuhn merged patch set 3 08/24/22, 10:53