Review main Merged

75549[TASK] Ensure php files contain correct legal file header

Stefan Bürk CR +2 V +2 Hard +253 −21 updated 08/26/22, 18:22

Commit message

Core php file header check got silently be disabled. Since
then the one or other file header error has slipped into
the core. It also pops up from time to time in reviews of
patches that file headers are missing (or are wrong).

This change ensures that file headers are checked again
and can be fixed by given contributers the proper tools
at hand.

Changes:

* add cglFixMyCommitFileHeader.(sh|bat)
* add cglHeader and cglHeaderGit to runTests.sh along
  with proper help text
* extend pre-commit hook to execute both fixer scripts
  side-by-side with error output and fixing possibility
* fix minor issue with header comment php-cs-fixer config

Additionally the cglHeader check is added to gitlab workflow
pre-merge (commit files) and nightly (all files).

Slipped in errors has been fixed with a dedicated change #98204.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 2

Files 8