Review main Merged

75552[BUGFIX] Allow BackedEnums for Extbase UriBuilder

Matthias Vogel CR +2 V +2 Normal +113 −0 updated 03/24/25, 08:14

Commit message

Since PHP 8 Extbase URLs could not handle
DomainObjects for the UriBuilder, which is now
added.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Matthias Vogel +1
    • Benni Mack +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 810

  1. Matthias Vogel uploaded patch set 1 08/26/22, 08:58

  2. core-ci voted on patch set 1 V +1 08/26/22, 09:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30457

  3. Benni Mack uploaded patch set 2 V +1 03/23/25, 23:57

  4. Benni Mack marked it ready for review 03/23/25, 23:57

  5. Benni Mack commented on patch set 2 CR +1 V +1 03/24/25, 00:00

    Thanks, Kanti. I took the liberty to finish this patch!
  6. core-ci voted on patch set 2 V +1 03/24/25, 00:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76109

  7. Matthias Vogel voted on patch set 2 CR +1 03/24/25, 06:57

  8. Georg Ringer voted on patch set 2 CR +2 V +2 03/24/25, 06:59

  9. Georg Ringer merged patch set 3 03/24/25, 06:59

  10. Simon Schaufelberger commented on patch set 3 03/24/25, 08:14

    UriBuilderTest.php:370 Unresolved

    2 spaces

    UriBuilderTest.php:523 Unresolved

    2 spaces