75552[BUGFIX] Allow BackedEnums for Extbase UriBuilder
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Matthias Vogel +1
- Benni Mack +1
-
Verified V +2 Done
- Georg Ringer +2
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 5
- typo3/sysext/extbase/Classes/Mvc/Web/Routing/UriBuilder.php+2 −0
- typo3/sysext/extbase/Tests/Fixture/IntegerBackedEnum.phpnew+25 −0
- typo3/sysext/extbase/Tests/Fixture/StringBackedEnum.phpnew+27 −0
- typo3/sysext/extbase/Tests/Fixture/UnbackedEnum.phpnew+25 −0
- typo3/sysext/extbase/Tests/Unit/Mvc/Web/Routing/UriBuilderTest.php2+34 −0
Review log 810
-
Matthias Vogel uploaded patch set 1 08/26/22, 08:58
-
core-ci voted on patch set 1 V +1 08/26/22, 09:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30457
-
Benni Mack uploaded patch set 2
V +103/23/25, 23:57 -
Benni Mack marked it ready for review 03/23/25, 23:57
-
Benni Mack commented on patch set 2 CR +1 V +1 03/24/25, 00:00
Thanks, Kanti. I took the liberty to finish this patch! -
core-ci voted on patch set 2 V +1 03/24/25, 00:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76109
-
Matthias Vogel voted on patch set 2 CR +1 03/24/25, 06:57
-
Georg Ringer voted on patch set 2 CR +2 V +2 03/24/25, 06:59
-
Georg Ringer merged patch set 3 03/24/25, 06:59
-
Simon Schaufelberger commented on patch set 3 03/24/25, 08:14
UriBuilderTest.php:370Unresolved2 spacesUriBuilderTest.php:523Unresolved2 spaces