Review main Merged

75555[TASK] Render toolbar items in Fluid

Andreas Kienast CR +2 V +2 Normal +97 −59 updated 09/02/22, 12:48

Commit message

Items were previously rendered in BackendController into a large HTML
string that was passed to Fluid. This commit resolves an open TODO and
moves the rendering of the toolbar items to the Topbar partial.

The data attribute `toolbar-identifier` is unused and therefore
removed.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 2029

Show 34 earlier messages
  1. Andreas Kienast uploaded patch set 1 08/26/22, 12:48

  2. Andreas Kienast uploaded patch set 2 08/26/22, 12:51

  3. Andreas Kienast updated the commit message in patch set 3 08/26/22, 12:53

  4. core-ci voted on patch set 1 V -1 08/26/22, 13:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30464

  1. core-ci voted on patch set 3 V +1 08/26/22, 13:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30466

  2. core-ci voted on patch set 2 V +1 08/26/22, 13:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30465

  3. Andreas Kienast commented on patch set 3 CR -1 08/26/22, 13:18

    Handling of remaining additionalAttributes is missing
  4. Andreas Kienast uploaded patch set 4 08/26/22, 13:33

  5. core-ci voted on patch set 4 V +1 08/26/22, 13:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30467

  6. Simon Schaufelberger commented on patch set 4 CR -1 08/28/22, 19:45

    AttributesViewHelper.php:37

    to a string

    Topbar.html:53

    add space before and after the arrow.

    Topbar.html:57

    above you used inline notation. use inline notation here as well.

    Topbar.html:60

    and here

    Topbar.html:64

    and here
  7. Andreas Kienast commented on patch set 4 09/02/22, 09:08

    AttributesViewHelper.php:37 Reply

    Ack

    Topbar.html:53 Reply

    IIRC there's no rule about this.

    Topbar.html:57 Reply

    Why? I don't have the need for inline here. Above I need it as I'm inside a tag.

    Topbar.html:60 Reply

    As stated above

    Topbar.html:64 Reply

    As stated above
  8. Andreas Kienast commented on patch set 5 09/02/22, 09:09

    Published edit on patch set 4.
  9. core-ci voted on patch set 5 V +1 09/02/22, 09:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30583

  10. Oli Bartsch uploaded patch set 6 09/02/22, 10:05

  11. Oli Bartsch voted on patch set 6 V +1 CR +1 09/02/22, 10:06

  12. core-ci voted on patch set 6 V -1 09/02/22, 10:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30586

  13. Andreas Kienast commented on patch set 6 09/02/22, 10:17

    AttributesViewHelper.php:41

    Must be `array{class?: ToolbarItemInterface}` (probably) to make phpstan happy
  14. Oli Bartsch uploaded patch set 7 09/02/22, 10:43

  15. core-ci voted on patch set 7 V +1 09/02/22, 10:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30592

  16. Oli Bartsch commented on patch set 7 V +1 CR +1 09/02/22, 10:52

    AttributesViewHelper.php:41 Reply

    Done
  17. Simon Schaufelberger uploaded patch set 8 09/02/22, 11:44

  18. Simon Schaufelberger commented on patch set 8 V +1 CR +1 09/02/22, 11:46

    Topbar.html:53 Reply

    the core does this everywhere!

    Topbar.html:57 Reply

    better readability

    Topbar.html:60 Reply

    Done

    Topbar.html:64 Reply

    Done
  19. Simon Schaufelberger uploaded patch set 9 09/02/22, 11:49

  20. Simon Schaufelberger voted on patch set 9 V +1 CR +1 09/02/22, 11:49

  21. core-ci voted on patch set 8 V +1 09/02/22, 11:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30594

  22. core-ci voted on patch set 9 V +1 09/02/22, 11:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30595

  23. Andreas Kienast commented on patch set 9 09/02/22, 12:46

    Topbar.html:53 Reply

    I'm sorry I didn't check other occurences...

    Topbar.html:57 Reply

    "better readability" is highly subjective in this regard, isn't it? Anyway, you changed it already and I don't care too much about syntactical sugar here.
  24. Oli Bartsch voted on patch set 9 V +2 CR +2 09/02/22, 12:48

  25. Oli Bartsch merged patch set 10 09/02/22, 12:48