75555[TASK] Render toolbar items in Fluid
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Simon Schaufelberger +1
-
Verified V +2 Done
- Oli Bartsch +2
- Simon Schaufelberger +1
- core-ci +1 CI
Issues 1
Files 3
Review log 2029
Show 34 earlier messages
-
Andreas Kienast uploaded patch set 1 08/26/22, 12:48
-
Andreas Kienast uploaded patch set 2 08/26/22, 12:51
-
Andreas Kienast updated the commit message in patch set 3 08/26/22, 12:53
-
core-ci voted on patch set 1 V -1 08/26/22, 13:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30464
-
core-ci voted on patch set 3 V +1 08/26/22, 13:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30466
-
core-ci voted on patch set 2 V +1 08/26/22, 13:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30465
-
Andreas Kienast commented on patch set 3 CR -1 08/26/22, 13:18
Handling of remaining additionalAttributes is missing -
Andreas Kienast uploaded patch set 4 08/26/22, 13:33
-
core-ci voted on patch set 4 V +1 08/26/22, 13:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30467
-
Simon Schaufelberger commented on patch set 4 CR -1 08/28/22, 19:45
AttributesViewHelper.php:37to a stringTopbar.html:53add space before and after the arrow.Topbar.html:57above you used inline notation. use inline notation here as well.Topbar.html:60and hereTopbar.html:64and here -
Andreas Kienast commented on patch set 4 09/02/22, 09:08
AttributesViewHelper.php:37ReplyAckTopbar.html:53ReplyIIRC there's no rule about this.Topbar.html:57ReplyWhy? I don't have the need for inline here. Above I need it as I'm inside a tag.Topbar.html:60ReplyAs stated aboveTopbar.html:64ReplyAs stated above -
Andreas Kienast commented on patch set 5 09/02/22, 09:09
Published edit on patch set 4. -
core-ci voted on patch set 5 V +1 09/02/22, 09:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30583
-
Oli Bartsch uploaded patch set 6 09/02/22, 10:05
-
Oli Bartsch voted on patch set 6 V +1 CR +1 09/02/22, 10:06
-
core-ci voted on patch set 6 V -1 09/02/22, 10:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30586
-
Andreas Kienast commented on patch set 6 09/02/22, 10:17
AttributesViewHelper.php:41Must be `array{class?: ToolbarItemInterface}` (probably) to make phpstan happy -
Oli Bartsch uploaded patch set 7 09/02/22, 10:43
-
core-ci voted on patch set 7 V +1 09/02/22, 10:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30592
-
Oli Bartsch commented on patch set 7 V +1 CR +1 09/02/22, 10:52
AttributesViewHelper.php:41ReplyDone -
Simon Schaufelberger uploaded patch set 8 09/02/22, 11:44
-
Simon Schaufelberger commented on patch set 8 V +1 CR +1 09/02/22, 11:46
Topbar.html:53Replythe core does this everywhere!Topbar.html:57Replybetter readabilityTopbar.html:60ReplyDoneTopbar.html:64ReplyDone -
Simon Schaufelberger uploaded patch set 9 09/02/22, 11:49
-
Simon Schaufelberger voted on patch set 9 V +1 CR +1 09/02/22, 11:49
-
core-ci voted on patch set 8 V +1 09/02/22, 11:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30594
-
core-ci voted on patch set 9 V +1 09/02/22, 11:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30595
-
Andreas Kienast commented on patch set 9 09/02/22, 12:46
Topbar.html:53ReplyI'm sorry I didn't check other occurences...Topbar.html:57Reply"better readability" is highly subjective in this regard, isn't it? Anyway, you changed it already and I don't care too much about syntactical sugar here. -
Oli Bartsch voted on patch set 9 V +2 CR +2 09/02/22, 12:48
-
Oli Bartsch merged patch set 10 09/02/22, 12:48