75562[BUGFIX] Ensure proper page visibility when backend user logged in
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 7
- typo3/sysext/core/Classes/Middleware/BackendUserAuthenticator.php+5 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/IrreCsv/DataSet/ImportDefaultWorkspaces.csv+5 −5
- typo3/sysext/core/Tests/Functional/DataScenarios/IrreCsv/WorkspacesModify/DataSet/deletePage.csv+6 −6
- typo3/sysext/core/Tests/Functional/DataScenarios/IrreForeignField/DataSet/ImportDefaultWorkspaces.csv+5 −5
- typo3/sysext/core/Tests/Functional/DataScenarios/IrreForeignField/WorkspacesModify/DataSet/deletePage.csv+6 −6
- typo3/sysext/core/Tests/Functional/DataScenarios/Regular/WorkspacesModify/DataSet/deletePage.csv+6 −6
- typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php+3 −5
Review log 1728
Show 23 earlier messages
-
Ingo Fabbri uploaded patch set 1 08/29/22, 16:33
-
Ingo Fabbri updated the commit message in patch set 2 08/29/22, 16:34
-
core-ci voted on patch set 1 V -1 08/29/22, 16:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30524
-
core-ci voted on patch set 2 V -1 08/29/22, 16:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30525
-
Ingo Fabbri uploaded patch set 3 08/30/22, 10:52
-
Ingo Fabbri uploaded patch set 4 08/30/22, 11:03
-
core-ci voted on patch set 3 V -1 08/30/22, 11:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30537
-
core-ci voted on patch set 4 V -1 08/30/22, 11:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30541
-
Oliver Klee updated the commit message in patch set 5 08/30/22, 11:36
-
core-ci voted on patch set 5 V -1 08/30/22, 11:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30542
-
Ingo Fabbri uploaded patch set 6 08/30/22, 11:47
-
core-ci voted on patch set 6 V -1 08/30/22, 11:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30543
-
Ingo Fabbri uploaded patch set 7 08/30/22, 12:19
-
core-ci voted on patch set 7 V -1 08/30/22, 12:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30544
-
Ingo Fabbri uploaded patch set 8 08/30/22, 12:47
-
core-ci voted on patch set 8 V -1 08/30/22, 12:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30545
-
Ingo Fabbri uploaded patch set 9 08/30/22, 13:06
-
core-ci voted on patch set 9 V -1 08/30/22, 13:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30546
-
Ingo Fabbri commented on patch set 9 CR -1 08/30/22, 14:10
I am too retarded for fixing the datasets. Can please someone either point me to the right direction or maybe fix it directly? -
Benni Mack updated the commit message in patch set 10
CR -1V -105/03/23, 09:22 -
core-ci voted on patch set 10 V -1 05/03/23, 10:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41404
-
Sybille Peters rebased onto patch set 11
V -109/15/23, 15:51 -
core-ci voted on patch set 11 V +1 09/15/23, 16:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46612
-
Sybille Peters commented on patch set 11 09/15/23, 16:12
I cannot reproduce the problem with extendToSubpages anymore in TYPO3 v12 and v13. I can still reproduce it with v11. Maybe the problem is already fixed? (The patch might still make sense, though). page A: hidden=1, extendToSubpages=1 -> page B (subpage): hidden =0 Loading page B (without adminpanel enables) results in 403 in v11, but is ok in v12 and v13. -
Oliver Hader updated the commit message in patch set 12
V +110/18/24, 14:12 -
Sybille Peters commented on patch set 12 03/06/25, 18:22
Reply
Correction: I can still reproduce problem with v12. It is really annoying. -
Sybille Peters commented on patch set 12 03/07/25, 14:23
I think this should be closed because the issue is not reproducible anymore with v12 and up, see issue https://forge.typo3.org/issues/87392 I previously said it was still reproducible, I could reproduce it on our production system, but I can't reproduce it on a latest branch 12.4 (12.4.28-dev) with base TYPO3 installation (t3coredev from git), so there may be something else wrong on our site or bug still exists in previous version 12.4.27. Also, the patch would need to be changed for "main" because a lot of stuff moved around, no longer in TypoScriptFrontendController. -
Ingo Fabbri abandoned the change 03/07/25, 14:32
Due to massive merge conflicts, broken tests and non-repro of extendToSubpages in v12+. I am happy to cancel/abandon this patch. After years.