Review 11.5 Merged

75575[TASK] Avoid unsolveable phpstan error for return-type mismatch

Christian Kuhn CR +2 V +2 Easy +1 −0 updated 09/02/22, 14:48

Commit message

PHP8.1 introduced native return types to native methods
and interfaces, which crashes if they are not compatible.
As a workaround the introduced `#[\ReturnTypeWillChange]`
attribute can be used to mitigate this, which has been
used to mitigate quite some issues with it.

PHPStan has released a new version which fixes a bunch
of bugs, which detects more issues in core. These will
be addressed with the dedicated PHPStan raise patch #98246.
However, one issue cannot be solved or added to the baseline
and must be fixed beforehand. The reason is, that phpstan
also evaluates the PHPDoc return type.

This change uses the `#[\ReturnTypeWillChange]` attribute
to silence this as a backportable intermediate solution.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 2

Files 1