75606[FEATURE] Option to configure primary actions in File List
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Benni Mack +1
-
Verified V +2 Done
- Andreas Kienast +2
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 2
Review log 2129
Show 34 earlier messages
-
Shehfinaz Kadavil uploaded patch set 1 09/05/22, 14:14
-
core-ci voted on patch set 1 V -1 09/05/22, 14:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30628
-
Benni Mack commented on patch set 1 09/05/22, 14:34
Thanks for the patch, I added some remarksDefaultConfiguration.php:1269I would not set this option in defaultConfiguration (instead provide the defaults in the PHP class directly) and only document this option in the RST (as you did).Feature-97821-OptionToConfigureDefaultIconsInFileList.rst:14do you want to give an example of the option ``` Example: options.file_list.defaultIcons = view,metadata,copy,cut,translations,delete ``` and maybe a list of icons we can set?FileList.php:1104please use the short-hand array syntax-FileList.php:1106you can use $this->getBackendUser() instead of $GLOBALS['BE_USER']. Also, we use `if ($userTsConfig['options.']['file_list.']['defaultIcons'] ?? false)` to avoid PHP 8 errors.FileList.php:1108we use single quotes, also we should use GeneralUtility::trimExplode() instead here. -
Shehfinaz Kadavil uploaded patch set 2 09/06/22, 09:23
-
Shehfinaz Kadavil commented on patch set 2 09/06/22, 09:26
Thanks for the feedback.DefaultConfiguration.php:1269ReplyDoneFeature-97821-OptionToConfigureDefaultIconsInFileList.rst:14ReplySorry, I forgot to provide the example. Will add the example in the next commit.FileList.php:1104ReplyDoneFileList.php:1106ReplyDoneFileList.php:1108ReplyDone -
core-ci voted on patch set 2 V -1 09/06/22, 09:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30642
-
Benni Mack commented on patch set 2 09/06/22, 09:34
FileList.php:1107try running ./Build/Scripts/cglFixMyCommit.sh which then fixes all indention problems, with PHP-CS-Fixer and your tests should become green -
Shehfinaz Kadavil uploaded patch set 3 09/06/22, 09:37
-
Shehfinaz Kadavil commented on patch set 2 09/06/22, 09:37
Feature-97821-OptionToConfigureDefaultIconsInFileList.rst:14ReplyDoneFileList.php:1107ReplyThanks -
core-ci voted on patch set 3 V +1 09/06/22, 09:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30644
-
Andreas Kienast commented on patch set 3 V -1 CR -1 09/06/22, 09:59
Two issues I noticed while testing: * Removing "translations" from the configuration renders a menu item in the "dotted" menu without a label * Adding "cut" and "copy" to the configuration renders an empty section in the "dotted" menuFeature-97821-OptionToConfigureDefaultIconsInFileList.rst:15Empty line before this oneFeature-97821-OptionToConfigureDefaultIconsInFileList.rst:16Please use the `code-block` role to add example code: https://docs.typo3.org/m/typo3/docs-how-to-document/main/en-us/WritingReST/Reference/Code/Codeblocks.htmlFileList.php:1104I think we could move the whole $defaultIcon block outside this foreach() loop.FileList.php:1107Missing space after =FileList.php:1111Please provide "true" as 3rd argument. -
Shehfinaz Kadavil uploaded patch set 4 09/06/22, 14:09
-
Shehfinaz Kadavil commented on patch set 4 09/06/22, 14:15
Reply
Hope it is resolved nowFeature-97821-OptionToConfigureDefaultIconsInFileList.rst:15ReplyDoneFeature-97821-OptionToConfigureDefaultIconsInFileList.rst:16ReplyDoneFileList.php:1104ReplyDoneFileList.php:1107ReplyDoneFileList.php:1111ReplyDone -
core-ci voted on patch set 4 V +1 09/06/22, 14:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30652
-
Andreas Kienast commented on patch set 4 V -1 09/06/22, 15:18
The issue regarding the "translations" button is still valid. -
Shehfinaz Kadavil uploaded patch set 5 09/07/22, 08:06
-
core-ci voted on patch set 5 V -1 09/07/22, 08:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30706
-
Andreas Kienast rebased onto patch set 6 09/07/22, 08:29
-
core-ci voted on patch set 6 V +1 09/07/22, 08:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30708
-
Andreas Kienast uploaded patch set 7 09/09/22, 09:28
-
Shehfinaz Kadavil commented on patch set 7 09/09/22, 09:31
Thanks for the change. It is more clear now. -
Andreas Kienast uploaded patch set 8 09/09/22, 09:33
-
core-ci voted on patch set 7 V +1 09/09/22, 09:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30898
-
Benni Mack voted on patch set 8 V +1 CR +1 09/09/22, 09:36
-
core-ci voted on patch set 8 V +1 09/09/22, 09:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30900
-
Andreas Kienast voted on patch set 8 V +2 CR +2 09/09/22, 09:43
-
Andreas Kienast merged patch set 9 09/09/22, 09:43
-
Lina Wolf commented on patch set 9 09/09/22, 15:25
The Changelog say "The actions that can be added are `view`, `metadata`, `copy` and `cut`" however the example mentions `delete` and `translations` is in the default values -
Andreas Kienast commented on patch set 9 09/09/22, 15:42
Reply
"translations" cannot be removed and "deleted" was forgotten.