Review main Merged

75621[BUGFIX] Trim provided external URL in linkwizard modal

Georg Ringer CR +2 V +2 Easy +2 −2 updated 09/08/22, 15:20

Commit message

Avoid mistakes, especially by copy & paste, and trim the given data
before closing the modal and delegating the data.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Jonas Eberle +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Jonas Eberle +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 67

  1. Georg Ringer uploaded patch set 1 09/06/22, 18:50

  2. Georg Ringer commented on patch set 1 09/06/22, 18:51

    This change is ready for review.
  3. core-ci voted on patch set 1 V +1 09/06/22, 18:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30670

  4. Andreas Kienast voted on patch set 1 V +1 CR +1 09/07/22, 07:40

  5. Jonas Eberle voted on patch set 1 V +1 CR +1 09/08/22, 15:16

  6. Andreas Kienast voted on patch set 1 V +2 CR +2 09/08/22, 15:20

  7. Andreas Kienast merged patch set 2 09/08/22, 15:20