Review 11.5 Merged

75627[BUGFIX] Avoid PHP warnings in recycler for records without cruser_id

Georg Ringer CR +2 V +2 Easy +4 −3 updated 11/08/22, 08:29

Commit message

Check if a record is using a "cruser_id" field before accessing it.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Oliver Klee +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1114

  1. Georg Ringer uploaded patch set 1 09/07/22, 05:34

  2. Georg Ringer commented on patch set 1 09/07/22, 05:35

    This change is ready for review.
  3. core-ci voted on patch set 1 V +1 09/07/22, 05:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30696

  4. Oliver Klee commented on patch set 1 09/07/22, 07:00

    RecyclerAjaxController.php:192

    Here, we should a string comparison for $usderIdField, as this check is about whether it’s a non-empty string, not whether is it truthey.

    RecyclerAjaxController.php:203

    Ditto.
  5. Benni Mack commented on patch set 2 11/04/22, 10:08

    Published edit on patch set 1.
  6. Oliver Klee commented on patch set 2 CR +1 11/04/22, 10:11

    RecyclerAjaxController.php:192 Reply

    Done

    RecyclerAjaxController.php:203 Reply

    Done
  7. core-ci voted on patch set 2 V +1 11/04/22, 10:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33098

  8. Benni Mack voted on patch set 2 V +1 CR +1 11/04/22, 14:06

  9. Oli Bartsch updated the commit message in patch set 3 11/04/22, 16:12

  10. Oli Bartsch voted on patch set 3 V +1 CR +1 11/04/22, 16:12

  11. Oliver Klee voted on patch set 3 CR +1 11/04/22, 16:17

  12. core-ci voted on patch set 3 V +1 11/04/22, 16:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33134

  13. Christian Kuhn voted on patch set 3 V +2 CR +2 11/08/22, 08:29

  14. Christian Kuhn merged patch set 4 11/08/22, 08:29