Review main Merged

75653[TASK] Remove jQuery from create multiple pages wizard

Oli Bartsch CR +2 V +2 Easy +20 −19 updated 09/07/22, 17:33

Commit message

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Anja Leichsenring +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Anja Leichsenring +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 67

  1. Oli Bartsch uploaded patch set 1 09/07/22, 11:02

  2. core-ci voted on patch set 1 V +1 09/07/22, 11:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30738

  3. Andreas Kienast commented on patch set 1 09/07/22, 14:44

    new-multiple-pages.ts:41

    Is this necessary at all?
  4. Andreas Kienast commented on patch set 1 V +1 CR +1 09/07/22, 14:49

    new-multiple-pages.ts:41 Reply

    It is, `this.lineCounter` is used in the callback.
  5. Anja Leichsenring voted on patch set 1 V +1 CR +1 09/07/22, 16:55

  6. Oli Bartsch voted on patch set 1 V +2 CR +2 09/07/22, 17:33

  7. Oli Bartsch merged patch set 2 09/07/22, 17:33