Review main Merged

75663[BUGFIX] Properly evaluate whether toolbar item provides a dropdown

Oli Bartsch CR +2 V +2 Easy +43 −2 updated 09/08/22, 15:19

Commit message

The ToolbarItemInterface requires the methods
hasDropDown() as well as getDropDown(). Since
#98214 the evaluation whether a toolbar item
provides a dropdown is done in Fluid, using the
corresponding magic "{toolbarItem.dropDown}".

Fluid however first checks for a "Getter" and
therefore uses the getDropDown() method instead
of the hasDropDown() method to determine whether
a toolbar item provides a dropdown. This led to
display errors in case a toolbar item only provides
a dropdown for some use cases as this was now
always used.

This is now fixed using a dedicated conditional
ViewHelper.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 2

Files 2