Review main Merged

75667[TASK] Provide more details when calling TSFE->set_no_cache()

Benni Mack CR +2 V +2 Easy +13 −9 updated 09/08/22, 18:08

Commit message

When TSFE->set_no_cache() is called without a reason
(usually through third-party code), the Logger now
ships with more information such as the class name and
function / method name, which was previously just the
filename.

If the code was called from outside a PHP class,
which is very uncommon in 2022, then just the filename
without the path is now put into the context of the Logger.

This way, a nasty hack around resolving symlinks
can be removed.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Susi Moog +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Susi Moog +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 79

  1. Benni Mack uploaded patch set 1 09/08/22, 17:06

  2. core-ci voted on patch set 1 V -1 09/08/22, 17:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30848

  3. Oli Bartsch uploaded patch set 2 09/08/22, 17:41

  4. Oli Bartsch voted on patch set 2 V +1 CR +1 09/08/22, 17:42

  5. core-ci voted on patch set 2 V +1 09/08/22, 17:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30857

  6. Susi Moog voted on patch set 2 CR +1 09/08/22, 17:50

  7. Susi Moog voted on patch set 2 V +1 09/08/22, 17:58

  8. Oli Bartsch voted on patch set 2 V +2 CR +2 09/08/22, 18:08

  9. Oli Bartsch merged patch set 3 09/08/22, 18:08