Review main Merged

75671[TASK] Use accessible labels and css classes in table wizard modals

Benjamin Franzke CR +2 V +2 Normal +59 −61 updated 09/25/24, 09:09

Commit message

Also use lit templating which is possible since the migration of the
modal component to lit in #98288.

Also polish some component details: Notify changes and remove table
center.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Jasmina Ließmann +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Jasmina Ließmann +1
    • core-ci +1 CI

Issues 2

Files 3

Review log 1521

  1. Benjamin Franzke uploaded patch set 1 09/09/22, 07:30

  2. core-ci voted on patch set 1 V +1 09/09/22, 07:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30880

  3. Benjamin Franzke marked it work in progress 05/30/24, 07:12

  4. Benjamin Franzke uploaded patch set 2 V +1 09/23/24, 13:20

  5. Benjamin Franzke marked it ready for review 09/23/24, 13:20

  6. core-ci voted on patch set 2 V +1 09/23/24, 13:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66441

  7. Benjamin Franzke uploaded patch set 3 V +1 09/23/24, 13:34

  8. Benjamin Franzke uploaded patch set 4 09/23/24, 13:37

  9. Andreas Kienast voted on patch set 4 CR +1 V +1 09/23/24, 13:41

  10. core-ci voted on patch set 3 V -1 09/23/24, 13:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66443

  11. core-ci voted on patch set 4 V +1 09/23/24, 13:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66444

  12. Jasmina Ließmann commented on patch set 4 09/23/24, 18:26

    table-wizard-element.ts:176

    IMHO I would keep `table-center` or at least add "text-center" to the thead > tr. Reason: When the "Small Fields" button is enabled, the buttons of the first and second column are too close together.
  13. Benjamin Franzke uploaded patch set 5 CR +1 V +1 09/25/24, 07:51

  14. Benjamin Franzke commented on patch set 5 09/25/24, 07:51

    table-wizard-element.ts:176 Reply

    alright, the interface needs some general overhaul, but that's better for a separate change.
  15. Jasmina Ließmann voted on patch set 5 CR +1 V +1 09/25/24, 07:53

  16. core-ci voted on patch set 5 V -1 09/25/24, 08:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66550

  17. Andreas Kienast uploaded patch set 6 CR +1 V +1 09/25/24, 08:48

  18. core-ci voted on patch set 6 V +1 09/25/24, 08:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66557

  19. Jasmina Ließmann voted on patch set 6 CR +1 V +1 09/25/24, 08:56

  20. Andreas Kienast voted on patch set 6 CR +2 V +2 09/25/24, 08:58

  21. Andreas Kienast merged patch set 7 09/25/24, 09:09