Review main Merged

75681[TASK] Remove wrong doc comments in \TYPO3\CMS\Core\Database\Connection

Torben Hansen CR +2 V +2 Easy +0 −6 updated 09/16/22, 11:51

Commit message

The doc comments for some functions in `\TYPO3\CMS\Core\Database\Connection`
state, that table expressions and columns are not escaped. This is actually
not true and it seems those doc comments have been adopted directly from
`doctrine/dbal` back in 2016, when Doctrine DBAL was introduced to TYPO3.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Thomas Löffler +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 56

  1. Torben Hansen uploaded patch set 1 09/09/22, 14:09

  2. core-ci voted on patch set 1 V +1 09/09/22, 14:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30933

  3. Thomas Löffler voted on patch set 1 CR +1 09/12/22, 15:05

  4. Stefan Bürk voted on patch set 1 V +1 CR +1 09/16/22, 11:51

  5. Christian Kuhn voted on patch set 1 V +2 CR +2 09/16/22, 11:51

  6. Christian Kuhn merged patch set 2 09/16/22, 11:51