Review 11.5 Merged

75713[SECURITY] Encode child node variables in f:asset.css view helper

Oliver Hader CR +2 V +2 Normal +75 −1 updated 09/13/22, 09:17

Commit message

Variables in child nodes like `<f:asset.css>{value}</f:asset.css>`
were not encoded and allow cross-site scripting. In case values shall
be taken as is, corresponding `f:format.raw` instruction has to be used.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
  • Verified V +2 Done
    • Oliver Hader +2

Issues 1

Files 2

Review log 34

  1. Oliver Hader uploaded patch set 1 09/13/22, 08:07

  2. Oliver Hader commented on patch set 1 V +2 CR +2 09/13/22, 08:07

    Auto-approved
  3. Oliver Hader merged patch set 2 09/13/22, 08:07

  4. core-ci voted on patch set 1 V +1 09/13/22, 09:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31021