Review main Merged

75717[SECURITY] Respect expiration time of password reset token

Oliver Hader CR +2 V +2 Easy +5 −0 updated 09/13/22, 09:21

Commit message

When a TYPO3 backend user performs a password reset request, a
password reset link including an expiration time is sent to the
user. The expiration time is included in HMAC calculation of
the saved password reset hash, but it is never evaluated if the
expiration time is exceeded.

This change adds the missing validity check for the expiration
time included in the password reset link.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
  • Verified V +2 Done
    • Oliver Hader +2

Issues 1

Files 1

Review log 34

  1. Oliver Hader uploaded patch set 1 09/13/22, 08:09

  2. Oliver Hader commented on patch set 1 V +2 CR +2 09/13/22, 08:09

    Auto-approved
  3. Oliver Hader merged patch set 2 09/13/22, 08:09

  4. core-ci voted on patch set 1 V +1 09/13/22, 09:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31031