Merge conflict Gerrit cannot merge this change. It needs a rebase onto main.
75727[TASK] Embed the logo into TYPO3 system mails
Commit message
Test this change
Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch
- Check out patch set 21
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/27/75727/21 && git checkout FETCH_HEAD - Cherry-pick onto main
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/27/75727/21 && git cherry-pick FETCH_HEAD
Review
-
Code review CR 0 Needs a vote
-
Verified V 0 Needs a vote
- core-ci +1 CI
Relation chain 3
-
main
75981[BUGFIX] Uninitialized properties in DebuggerUtility
The chain has patch set 3 of 6, the changes above it need a rebase.
-
main
75975[FEATURE] Username in password recovery mail
The chain has patch set 3 of 12, the changes above it need a rebase.
-
75727 [TASK] Embed the logo into TYPO3 system mails This change
Issues 2
Files 8
- typo3/sysext/backend/Classes/View/AuthenticationStyleInformation.php+6 −1
- typo3/sysext/backend/Classes/ServiceProvider.php+20 −0
- typo3/sysext/core/Classes/Mail/FluidEmail.php14+114 −1
- typo3/sysext/core/Documentation/Changelog/14.3.x/Important-98343-LogoOfSystemMailsIsEmbedded.rst2new+66 −0
- typo3/sysext/core/Resources/Private/Layouts/SystemEmail.fluid.html+2 −11
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_fluid_email/Resources/Private/Templates/WithoutSystemEmailLayout.fluid.htmlnew+1 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_fluid_email/Resources/Private/Templates/WithoutSystemEmailLayout.fluid.txtnew+1 −0
- typo3/sysext/core/Tests/Functional/Mail/FluidEmailTest.php1+207 −4
Review log 5778
Show 3753 earlier messages
-
Mario Lubenka uploaded patch set 1 09/13/22, 15:33
-
Mario Lubenka uploaded patch set 2 09/13/22, 15:39
-
Simon Schaufelberger commented on patch set 2 CR -1 09/13/22, 15:42
FluidEmail.php:74I'm not sure if the Environment would be a better source for the document root here. Make sure this also works in CI context! -
core-ci voted on patch set 1 V -1 09/13/22, 15:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31060
-
core-ci voted on patch set 2 V -1 09/13/22, 15:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31061
-
Mario Lubenka uploaded patch set 3 09/13/22, 15:50
-
Mario Lubenka commented on patch set 2 09/13/22, 15:50
FluidEmail.php:67ReplyDoneFluidEmail.php:74ReplyThe goal is to get the absolute path of the file. If there is a CI-proof way of doing so, please let me know. :) -
Simon Schaufelberger commented on patch set 3 09/13/22, 15:52
FluidEmail.php:74ReplyAs I said, the class \TYPO3\CMS\Core\Core\Environment provides all base paths -
core-ci voted on patch set 3 V -1 09/13/22, 15:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31062
-
Benni Mack commented on patch set 3 09/13/22, 16:17
SystemEmail.html:353what's "cid" ? :) -
Simon Schaufelberger commented on patch set 3 09/13/22, 18:20
SystemEmail.html:353Replythat is the way how to embed inline images in emails -
Mario Lubenka uploaded patch set 4 09/14/22, 06:27
-
core-ci voted on patch set 4 V -1 09/14/22, 06:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31073
-
Mario Lubenka uploaded patch set 5 09/14/22, 09:12
-
core-ci voted on patch set 5 V +1 09/14/22, 09:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31077
-
Mario Lubenka commented on patch set 5 09/14/22, 09:25
FluidEmailTest.php:64Not sure why format changed here. In any case I made sure to only add the logo for HTML format. Embedding the logo changes the media subtype to "related" for HTML and BOTH format -
Stefan Bürk commented on patch set 5 09/17/22, 19:44
I think, this should be done as FEATURE and with some kind of option (opt-in or opt-out). Embeding images in mails may leead to increased spam detection, depending on recieving servers. There are spam filtes out in the wild. So we should not hard enforce this here. It would mean, that we had to hack/patch the core to revert the embending if this goes in in the current implementation in the future. I get the point with "missing" image after a longer time - we personally have static hosted images for images and resources used in mails, which will not be deleted. Granted, that helps not with offline mail viewing .. but is than a missing image not a real issue. It's offline view of a html mail. And I would not take this as task .. and not as backport. I would guess, that backporting this would get regression voices raised. This just from viewing. Not tested the patch itself yet. >> This should be changed to a FEATURE with opt-in option (must be explicitly enabled) and main only -
Mario Lubenka uploaded patch set 6 09/19/22, 09:17
-
Mario Lubenka commented on patch set 6 09/19/22, 09:20
Reply
I changed it to a FEATURE for v12 only. We'll be applying it to our v11 project via Composer patches then until we can upgrade to v12 sometime next year. -
Mario Lubenka commented on patch set 6 09/19/22, 09:20
SystemEmail.html:353ReplyDone -
core-ci voted on patch set 6 V -1 09/19/22, 09:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31260
-
Mario Lubenka uploaded patch set 7 09/19/22, 09:50
-
core-ci voted on patch set 7 V -1 09/19/22, 09:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31262
-
Mario Lubenka uploaded patch set 8 09/19/22, 10:01
-
core-ci voted on patch set 8 V +1 09/19/22, 10:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31263
-
Simon Schaufelberger commented on patch set 8 09/19/22, 11:58
FluidEmail.php:63please don't touch code that doesn't need to be changed. -
Anja Leichsenring commented on patch set 8 09/19/22, 16:49
now a feature.rst file is missing for the change to be ready -
Mario Lubenka uploaded patch set 9 09/20/22, 06:05
-
Mario Lubenka uploaded patch set 10 09/20/22, 06:10
-
Mario Lubenka commented on patch set 10 09/20/22, 06:10
FluidEmail.php:63ReplyDone -
core-ci voted on patch set 9 V +1 09/20/22, 06:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31302
-
core-ci voted on patch set 10 V +1 09/20/22, 06:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31303
-
Georg Ringer commented on patch set 10 10/01/22, 20:01
I would be in favor of no extra setting. always provide the logo path to the template + the embeddedLogo if possible (E.g. not if a an external URL is provided). if available, always embed. what do you think? -
Benjamin Franzke commented on patch set 10 10/01/22, 20:03
Reply
+1 -
Benni Mack commented on patch set 10 10/01/22, 21:40
Reply
yes. let's drop the option then -
Mario Lubenka uploaded patch set 11 10/04/22, 06:33
-
Mario Lubenka commented on patch set 11 10/04/22, 06:34
Reply
Option dropped again :) -
core-ci voted on patch set 11 V +1 10/04/22, 06:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31965
-
Georg Ringer commented on patch set 11 10/04/22, 06:44
FluidEmail.php:193it is possible that this logo can not be retrieved e.g. when provided via https://domain.tld/logo.svg I propose to return an empty string or null then and in ::returnContent check if the logoPath is available. in the template use the existing code as fallback then. what do you thinkDefaultConfiguration.php:1400still thereFeature-98343-EmbeddedFluidSystemEmailLogo.rst:22propose to change to "Install Tool". the LocalConfiguration file doesn't exist anymore since couple of days -
Mario Lubenka uploaded patch set 12 10/04/22, 07:04
-
Mario Lubenka commented on patch set 11 10/04/22, 07:04
FluidEmail.php:193ReplyHm. I looked at the usage of `$GLOBALS['TYPO3_CONF_VARS']['EXTENSIONS']['backend']['loginLogo']` in Ext:backend. Here, external URLs just pass through. Therefore I would not add an additional check here and make it the responsibility of the TYPO3 integrator that is configuring a custom logo.DefaultConfiguration.php:1400ReplyDoneFeature-98343-EmbeddedFluidSystemEmailLogo.rst:22ReplyAh, good to know. Changed. -
core-ci voted on patch set 12 V +1 10/04/22, 07:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31966
-
Mario Lubenka uploaded patch set 13 10/04/22, 10:17
-
core-ci voted on patch set 13 V +1 10/04/22, 10:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31972
-
Chris Müller commented on patch set 13 10/04/22, 11:46
Feature-98343-EmbeddedFluidSystemEmailLogo.rst:12fluid -> FluidFeature-98343-EmbeddedFluidSystemEmailLogo.rst:20Please use 4 spaces for indenting, not tabs. -
Mario Lubenka uploaded patch set 14 10/04/22, 14:44
-
Mario Lubenka commented on patch set 14 10/04/22, 14:45
ThanksFeature-98343-EmbeddedFluidSystemEmailLogo.rst:12ReplyDoneFeature-98343-EmbeddedFluidSystemEmailLogo.rst:20ReplyDone -
core-ci voted on patch set 14 V +1 10/04/22, 15:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31987
-
Mario Lubenka uploaded patch set 15 10/05/22, 06:24
-
Mario Lubenka uploaded patch set 16 10/05/22, 06:29
-
core-ci voted on patch set 15 V +1 10/05/22, 06:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32021
-
core-ci voted on patch set 16 V +1 10/05/22, 06:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32025
-
Mario Lubenka commented on patch set 16 02/08/23, 13:07
FluidEmail.php:193ReplyCan we proceed with this change as it is, or do we need to make changes to it? -
Chris Müller uploaded patch set 17
V +102/08/23, 17:40 -
core-ci voted on patch set 17 V -1 02/08/23, 18:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37393
-
Chris Müller uploaded patch set 18
V -102/08/23, 20:44 -
core-ci voted on patch set 18 V +1 02/08/23, 20:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37410
-
Sybille Peters commented on patch set 18 03/04/23, 10:48
SystemEmail.html:353If a custom logo is used, the alt text "TYPO3 Logo" is not appropriate. Please use "Logo" or set the alt text as well via variables. See also: https://forge.typo3.org/issues/100081 I would like to abandon my patch in favor of this one. (Unfortunately, I had already pushed when made aware of this patch). -
Sybille Peters commented on patch set 18 03/14/23, 17:22
SystemEmail.html:353Reply UnresolvedOn second thought, I think for decorative logos (without functionality, e.g. without link) an alt text should not be used at all. So we could just remove the alt text entirely for the logo, see https://www.w3.org/WAI/tutorials/images/decorative/ If you agree, I can fix the merge conflict and make the change. -
Markus Klein commented on patch set 18 03/14/23, 21:39
FluidEmail.php:193Reply`\TYPO3\CMS\Backend\View\AuthenticationStyleInformation::getUriForFileName` has an explicit check whether this is a URL already or not. In that case here we fail due to prepending the slash -
Simon Schaufelberger commented on patch set 18 09/04/23, 02:54
FluidEmail.php:193ReplyMario,FluidEmail.php:193Reply UnresolvedMario, I would like to motivate you to finish this patch and make it mergeable! ;) -
Anja Leichsenring wrote 07/31/24, 18:24
Removed cc Anja Leichsenring. -
Benni Mack uploaded patch set 19
V +104/11/25, 18:37 -
core-ci voted on patch set 19 V +1 04/11/25, 18:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77572
-
Helmut Hummel commented on patch set 19 10/22/25, 09:50
Once https://review.typo3.org/c/Packages/TYPO3.CMS/+/90675 is merged, implementation of this can be made much cleaner and more straightforward. my suggestion therefore is to wait until merge and continue here then -
Helmut Hummel voted on patch set 19 V -1 10/22/25, 09:50
-
Sybille Peters wrote 10/22/25, 10:05
Removed cc Sybille Peters. -
Benni Mack wrote 04/21/26, 14:54
Removed cc Benni Mack. -
Benni Mack marked it work in progress 04/21/26, 14:54
-
Benni Mack uploaded patch set 20
V +109/03/26, 22:05 -
core-ci voted on patch set 20 V +1 09/03/26, 22:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107784
-
Garvin Hicking commented on patch set 20 09/04/26, 06:35
Important-98343-LogoOfSystemMailsIsEmbedded.rst:46We need to mention that setups with large logo files may considerable increase mail traffic when the template is used for many recipients (eg communities with notifications). We should note that custom templates can implement their own img tag with an EXT notation or using typo3.systemConfiguration.backend.loginLogo if this is not wanted? If you agree I can provide a wording suggestion. -
Garvin Hicking commented on patch set 21
V +109/04/26, 10:05Published edit on patch set 20. -
Garvin Hicking commented on patch set 21 09/04/26, 10:13
Important-98343-LogoOfSystemMailsIsEmbedded.rst:46Reply Unresolvedplease see my proposal -
core-ci voted on patch set 21 V +1 09/04/26, 10:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107851
-
Markus Klein commented on patch set 21 09/06/26, 19:20
Sidenote: we simply use a viewhelper for embedding things: https://gitlab.com/reelworx/typo3/t3-mailservice/-/blob/master/src/ViewHelper/ImageCidViewHelper.php?ref_type=heads -
Chris Müller wrote 09/07/26, 06:53
Removed cc Chris Müller.
FluidEmail.php:67