Review main Merged

75744[BUGFIX] Fix avatar sizes and use medium size in SetupModuleController

Andreas Kienast CR +2 V +2 Easy +8 −8 updated 09/16/22, 12:24

Commit message

If no size is explicitly given, the avatar size is based on the text
size, similar to icons. In the SetupModuleController, this lead to an
itty bitty small avatar image.

This fix discovered a CSS bug where the avatar classes used the wrong
CSS variables for sizing.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Stefan Bürk +1
    • Christian Kuhn +1
    • Benjamin Kott +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Stefan Bürk +1
    • Christian Kuhn +1
    • Benjamin Kott +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 67

  1. Andreas Kienast uploaded patch set 1 09/16/22, 12:16

  2. Benjamin Kott voted on patch set 1 V +1 CR +1 09/16/22, 12:18

  3. Christian Kuhn voted on patch set 1 V +1 CR +1 09/16/22, 12:19

  4. Stefan Bürk voted on patch set 1 V +1 CR +1 09/16/22, 12:19

  5. core-ci voted on patch set 1 V +1 09/16/22, 12:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31188

  6. Andreas Kienast voted on patch set 1 V +2 CR +2 09/16/22, 12:24

  7. Andreas Kienast merged patch set 2 09/16/22, 12:24