Review main Merged Breaking

75749[!!!][TASK] Cleanup and harden Extbase Request

Christian Kuhn CR +2 V +2 Expert +402 −674 updated 09/18/22, 17:51

Commit message

The Extbase Request has been turned into a
PSR-7 decorator in v11. Most interface changes
have not been enforced in v11 though, since that
would have been breaking at this point in the
release cycle.

With v12, we can now activate the RequestInterface
changes. The patch does this, and migrates the "setX()"
that violate PSR-7 request immutability towards
their 'withX()' counterparts which create new
objects.

The patch adds quite a bit of syntactic sugar to
consuming classes: core phpstan is significantly more
happy and extbase extension devs benefit from
improved type hints and interface coverage.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 2

Files 32

Show 12 more files