Review main Merged

75773[TASK] Deprecate StandaloneView getters

Christian Kuhn CR +2 V +2 Normal +76 −12 updated 08/01/24, 21:09

Commit message

Views should be data sinks, but not data sources:
In Fluid, RenderingContext is the main state object
used to carry rendering related state.

As such, StandaloneView should not provide getter
methods to retrieve state after it has been set:
They could be misused to "park" state, which is
a sign of bad architecture since only controllers
should keep track, carry and update such state.

The patch deprecates offending methods in
StandaloveView.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1015

  1. Christian Kuhn uploaded patch set 1 09/18/22, 17:16

  2. core-ci voted on patch set 1 V -1 09/18/22, 17:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31247

  3. Christian Kuhn uploaded patch set 2 09/18/22, 17:53

  4. core-ci voted on patch set 2 V +1 09/18/22, 18:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31248

  5. Christian Kuhn uploaded patch set 3 09/18/22, 18:25

  6. Christian Kuhn updated the commit message in patch set 4 09/18/22, 18:27

  7. Christian Kuhn uploaded patch set 5 09/18/22, 18:31

  8. core-ci voted on patch set 3 V +1 09/18/22, 18:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31249

  9. Stefan Bürk voted on patch set 5 V +1 CR +1 09/18/22, 18:39

  10. core-ci voted on patch set 5 V +1 09/18/22, 18:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31251

  11. core-ci voted on patch set 4 V +1 09/18/22, 18:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31250

  12. Simon Schaufelberger voted on patch set 5 V +1 CR +1 09/18/22, 18:58

  13. Stefan Bürk voted on patch set 5 V +2 CR +2 09/18/22, 18:59

  14. Stefan Bürk merged patch set 6 09/18/22, 18:59

  15. Lina Wolf commented on patch set 5 V +1 CR +1 09/18/22, 18:59

    Tested with frontend_login, forms, blog_example, tea, code looks good.