Review main Merged

75783[TASK] Type hint ext:fluid RenderingContext

Christian Kuhn CR +2 V +2 Hard +115 −137 updated 09/20/22, 07:21

Commit message

The ext:fluid RenderingContext extends standalone fluid
RenderingContextInterface by adding getRequest(). This
object is always carried around in TYPO3 fluid universe.

When calling getRequest() in ViewHelpers, IDE's and
static analyzers don't know about this inheritance.
Unfortunately, we can't change standalone fluid at the
moment since that would be breaking, and we can't
change VH's method signatures either since that would
violate contravariance.

For now, we add a series on @var hints within various
ViewHelpers to make phpstan and IDE's more happy.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 24

Show 4 more files