Review main Merged

75794[TASK] Simplify access to fallback target in link building

Benni Mack CR +2 V +2 Easy +17 −8 updated 10/05/22, 08:01

Commit message

This change moves the access of the link target
for files / external URLs and pages into the
actual AbstractTypolinkBuilder to increases readability
and to avoid errors when using the method.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Christian Kuhn +1
    • Susi Moog +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 79

  1. Benni Mack uploaded patch set 1 09/20/22, 10:38

  2. core-ci voted on patch set 1 V +1 09/20/22, 10:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31308

  3. Benni Mack updated the commit message in patch set 2 09/20/22, 10:48

  4. core-ci voted on patch set 2 V +1 09/20/22, 11:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31311

  5. Susi Moog voted on patch set 2 CR +1 09/20/22, 13:20

  6. Oli Bartsch voted on patch set 2 V +1 CR +1 10/05/22, 07:51

  7. Christian Kuhn voted on patch set 2 V +1 CR +1 10/05/22, 08:00

  8. Benni Mack voted on patch set 2 V +2 CR +2 10/05/22, 08:01

  9. Benni Mack merged patch set 3 10/05/22, 08:01