75797[TASK] Clean up AbstractUserAuthentication
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Oliver Hader +1
-
Verified V +2 Done
- Christian Kuhn +2
- Oliver Hader +1
- core-ci +1 CI
Issues 1
Files 2
Review log 2028
Show 23 earlier messages
-
Benni Mack uploaded patch set 1 09/20/22, 14:53
-
core-ci voted on patch set 1 V +1 09/20/22, 15:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31323
-
Benni Mack uploaded patch set 2 09/20/22, 15:22
-
Benni Mack uploaded patch set 3 09/20/22, 15:29
-
core-ci voted on patch set 2 V -1 09/20/22, 15:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31324
-
core-ci voted on patch set 3 V -1 09/20/22, 15:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31325
-
Benni Mack uploaded patch set 4 09/21/22, 07:08
-
core-ci voted on patch set 4 V -1 09/21/22, 07:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31336
-
Benni Mack uploaded patch set 5 09/21/22, 07:38
-
core-ci voted on patch set 5 V -1 09/21/22, 07:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31339
-
Benni Mack uploaded patch set 6 09/21/22, 08:46
-
Benni Mack updated the commit message in patch set 7 09/21/22, 08:48
-
core-ci voted on patch set 6 V +1 09/21/22, 08:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31341
-
core-ci voted on patch set 7 V +1 09/21/22, 08:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31342
-
Oliver Hader commented on patch set 7 09/21/22, 10:37
AbstractUserAuthentication.php:482It's like before, however `$anonymousSession` implies having `$isExistingSession` as well.AbstractUserAuthentication.php:487`$authenticatedUserFromSession !== null`?AbstractUserAuthentication.php:529Is this correct? `$authenticatedUserFromSession` is `$authInfo['user']`, isn't it? -
Oliver Hader commented on patch set 7 V +1 09/21/22, 10:46
See my comments code-wise. However, from a testing POV it worksAbstractUserAuthentication.php:529ReplyAha, that's merged in `getAuthServices` now...AbstractUserAuthentication.php:744From my POV changing the meaning of `$authInfo` to `$authenticatedUserFromSession` is worth documentation. I fear `getAuthServices` might be used by custom implementations as well.. -
Frank Nägler commented on patch set 7 09/21/22, 12:17
AbstractUserAuthentication.php:457ReplyI agree, this comment confuses me 😊 -
Oliver Klee commented on patch set 7 09/21/22, 12:19
AbstractUserAuthentication.php:487ReplyOr even more explicit: `$authenticatedUserFromSession instanceof …` -
Benni Mack commented on patch set 7 09/21/22, 12:26
AbstractUserAuthentication.php:457Replyyes. the comment is wrong.AbstractUserAuthentication.php:487Replyinstanceof array? -
Oliver Klee commented on patch set 7 09/21/22, 12:42
AbstractUserAuthentication.php:487ReplyOh, sorry, of course this should be: is_array($authenticatedUserFromSession) -
Benni Mack commented on patch set 7 09/21/22, 15:07
AbstractUserAuthentication.php:482Replyinteresting, I will document this.AbstractUserAuthentication.php:529Replyyes. previously this was merged into the main $authInfo array and it was never clear when $authInfo was used. For this reason, this is now better readable.AbstractUserAuthentication.php:744ReplyIn my previous v10/v11 projects with custom authentication providers, I already use "$authInfo['user']", so this ain't a change in behaviour. I do however want to proceed in making this more explicit (as an object), which is when I would document this at that point. OK? -
Benni Mack uploaded patch set 8 09/21/22, 15:07
-
Benni Mack commented on patch set 7 09/21/22, 15:08
AbstractUserAuthentication.php:457ReplyDoneAbstractUserAuthentication.php:482ReplyDoneAbstractUserAuthentication.php:487ReplyDoneAbstractUserAuthentication.php:529ReplyDone -
core-ci voted on patch set 8 V +1 09/21/22, 15:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31384
-
Oliver Hader commented on patch set 8 V +1 CR +1 09/21/22, 15:19
AbstractUserAuthentication.php:744ReplyI'd highly appreciate and welcome that (having a model here) 👍 Fine! -
Benni Mack commented on patch set 8 09/21/22, 15:29
AbstractUserAuthentication.php:744ReplyDone -
Christian Kuhn voted on patch set 8 V +2 CR +2 09/21/22, 15:49
-
Christian Kuhn merged patch set 9 09/21/22, 15:49
AbstractUserAuthentication.php:457