Review main Merged

75800[BUGFIX] Replace deprecated source-sans-pro with source-sans

Andreas Kienast CR +2 V +2 Normal +120 −121 updated 09/21/22, 14:37

Commit message

The package `source-sans-pro` was renamed to `source-sans` in September
2020. npm annotates this deprecation during installation of packages as
well.

As all font files were renamed, the SCSS file and the font directory
were renamed accordingly.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Christian Kuhn +1
    • Benni Mack +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Christian Kuhn +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 61

Show 41 more files

Review log 810

  1. Andreas Kienast uploaded patch set 1 09/21/22, 11:58

  2. Andreas Kienast commented on patch set 1 CR -2 09/21/22, 12:07

    Since the font family's name was changed, I consulted Benni whether this patch qualifies as breaking.
  3. core-ci voted on patch set 1 V +1 09/21/22, 12:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31356

  4. Andreas Kienast voted on patch set 1 CR 0 09/21/22, 12:18

  5. Andreas Kienast uploaded patch set 2 09/21/22, 13:06

  6. core-ci voted on patch set 2 V +1 09/21/22, 13:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31369

  7. Christian Kuhn voted on patch set 2 V +1 CR +1 09/21/22, 13:31

  8. Benni Mack voted on patch set 2 V +1 CR +1 09/21/22, 14:35

  9. Andreas Kienast voted on patch set 2 V +2 CR +2 09/21/22, 14:37

  10. Andreas Kienast merged patch set 3 09/21/22, 14:37