Review main Merged

75811[BUGFIX] Prevent undefined array keys in AbstractMenuContentObject

Oli Bartsch CR +2 V +2 Easy +2 −2 updated 09/21/22, 21:02

Commit message

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Oliver Klee +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 78

  1. Oli Bartsch uploaded patch set 1 09/21/22, 15:29

  2. core-ci voted on patch set 1 V +1 09/21/22, 15:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31389

  3. Nikita Hovratov commented on patch set 1 09/21/22, 15:42

    AbstractMenuContentObject.php:1055

    Should we maybe use null instead of false, as it is in the is_array() context and not directly in the if condition?
  4. Christian Kuhn commented on patch set 1 V +1 CR +1 09/21/22, 15:54

    AbstractMenuContentObject.php:1055 Reply

    that's matter of taste without much impact, i think the intention here is clear. could be kept as is.
  5. Oliver Klee voted on patch set 1 CR +1 09/21/22, 15:56

  6. Jochen Roth voted on patch set 1 V +1 CR +1 09/21/22, 20:58

  7. Oli Bartsch voted on patch set 1 V +2 CR +2 09/21/22, 21:01

  8. Oli Bartsch merged patch set 2 09/21/22, 21:02